You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@linkis.apache.org by GitBox <gi...@apache.org> on 2021/10/29 07:47:58 UTC
[GitHub] [incubator-linkis] lunescode opened a new pull request #1052: bug: when hostname start with applicationName, will cause parse faile…
lunescode opened a new pull request #1052:
URL: https://github.com/apache/incubator-linkis/pull/1052
### What is the purpose of the change
when hostname start with applicationName, will cause parse failed, resuslt in can't find instace from eureka.
for example,
hostname："linkis-cg-linkis-cg-engineconnmanager-1"
aplicationName: "linkis-cg-engineconnmanager"
he service registed in eureka: "linkis-cg-linkis-cg-engineconnmanager-1:linkis-cg-linkis-cg-engineconnmanager:9102"
the code "instanceId.toLowerCase.indexOf(applicationName.toLowerCase)" will return 0.
### Brief change log
- More stringent match in the code line 42 of EurekaRPCServerLoader.java
### Verifying this change
This change added tests and can be verified as follows:
- 1. set engineconnmanager's hostname "linkis-cg-linkis-cg-engineconnmanager-1",which contains aplicationName "linkis-cg-engineconnmanager", then start all service.
- 2. start a shell engine, if execute success the pass the test.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- Anything that affects deployment: (no )
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #1052: bugFix: when hostname start with applicationName, will cause parse faile…
Posted by GitBox <gi...@apache.org>.
peacewong merged pull request #1052:
URL: https://github.com/apache/incubator-linkis/pull/1052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org