You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2023/05/16 18:27:51 UTC
[GitHub] [superset] rusackas opened a new pull request, #24081: chore(docs): Updating DB connection instructions in 1st Dash instruct…
rusackas opened a new pull request, #24081:
URL: https://github.com/apache/superset/pull/24081
…ions
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The docs for connecting to a DB in the "Creating Your First Dashboard" section were out of date. This PR updates the instructions a bit, and adds updated screenshots.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:
After:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24081: chore(docs): Updating DB connection instructions in 1st Dash instruct…
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24081:
URL: https://github.com/apache/superset/pull/24081#issuecomment-1550163366
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24081?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24081](https://app.codecov.io/gh/apache/superset/pull/24081?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1da6d0c) into [master](https://app.codecov.io/gh/apache/superset/commit/58e1bcde9e1643cb4f2b3855a586305e75e23f84?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (58e1bcd) will **decrease** coverage by `11.39%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 1da6d0c differs from pull request most recent head 272be01. Consider uploading reports for the commit 272be01 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24081 +/- ##
===========================================
- Coverage 68.25% 56.87% -11.39%
===========================================
Files 1942 1942
Lines 75192 75192
Branches 8145 8145
===========================================
- Hits 51322 42764 -8558
- Misses 21785 30343 +8558
Partials 2085 2085
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.12% <ø> (ø)` | |
| python | `59.36% <ø> (-23.48%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.11% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 307 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24081/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #24081: chore(docs): Updating DB connection instructions in 1st Dash instruct…
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24081:
URL: https://github.com/apache/superset/pull/24081#issuecomment-1550163760
@sfirke @kikobarr @eschutho here's the PR from today's lil' session, for your consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #24081: chore(docs): Updating DB connection instructions in 1st Dash instruct…
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #24081:
URL: https://github.com/apache/superset/pull/24081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org