You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/18 04:34:45 UTC

[GitHub] [spark] c21 commented on a change in pull request #32216: [SPARK-35118][SQL] Propagate empty relation through Join if join condition is empty

c21 commented on a change in pull request #32216:
URL: https://github.com/apache/spark/pull/32216#discussion_r615340012



##########
File path: sql/core/src/test/resources/sql-tests/results/join-empty-relation.sql.out
##########
@@ -71,15 +71,15 @@ SELECT * FROM t1 LEFT SEMI JOIN empty_table
 -- !query schema
 struct<a:int>
 -- !query output
-
+1

Review comment:
       does it look right or not? LEFT SEMI join with empty table should has no output, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org