You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/02 16:36:50 UTC

[GitHub] [kafka] tombentley opened a new pull request #8975: MINOR: Document that max.block.ms affects some transaction methods

tombentley opened a new pull request #8975:
URL: https://github.com/apache/kafka/pull/8975


   The documentation for max.block.ms said it affected only send()
   and partitionsFor(), but it actually also affects initTransactions(),
   abortTransaction() and commitTransaction(). So rework the
   documentation to cover these methods too.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] tombentley commented on pull request #8975: MINOR: Document that max.block.ms affects some transaction methods

Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #8975:
URL: https://github.com/apache/kafka/pull/8975#issuecomment-653416263


   Thanks @abbccdda, I reworded it slightly, hope that's OK.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] tombentley commented on pull request #8975: MINOR: Document that max.block.ms affects some transaction methods

Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #8975:
URL: https://github.com/apache/kafka/pull/8975#issuecomment-653110666


   @hachikuji please could you review this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] abbccdda commented on pull request #8975: MINOR: Document that max.block.ms affects some transaction methods

Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8975:
URL: https://github.com/apache/kafka/pull/8975#issuecomment-653723481


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] abbccdda merged pull request #8975: MINOR: Document that max.block.ms affects some transaction methods

Posted by GitBox <gi...@apache.org>.
abbccdda merged pull request #8975:
URL: https://github.com/apache/kafka/pull/8975


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org