You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2012/11/03 02:24:12 UTC
[jira] [Commented] (HADOOP-8820) Backport HADOOP-8469 and
HADOOP-8470: add "NodeGroup" layer in new NetworkTopology (also known as
NetworkTopologyWithNodeGroup)
[ https://issues.apache.org/jira/browse/HADOOP-8820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489896#comment-13489896 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-8820:
------------------------------------------------
> ... how does this patch marked as patch available for review?
You may simply post the patch on the JIRA.
The patch looks good. Some minor comments:
- The conf property net.topology.nodegroup.aware is not used. It is also not in the HADOOP-8469 and HADOOP-8470 patches. Let's add it in later patches.
- The netlock.writeLock().lock() below should be before try{}.
{code}
//NetworkTopologyWithNodeGroup.add(..)
+ try {
+ netlock.writeLock().lock();
+ Node rack = null;
{code}
Could you also run test-patch and all the unit tests with the new patch?
> Backport HADOOP-8469 and HADOOP-8470: add "NodeGroup" layer in new NetworkTopology (also known as NetworkTopologyWithNodeGroup)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8820
> URL: https://issues.apache.org/jira/browse/HADOOP-8820
> Project: Hadoop Common
> Issue Type: New Feature
> Components: net
> Affects Versions: 1.0.0
> Reporter: Junping Du
> Assignee: Junping Du
> Attachments: HADOOP-8820.patch
>
>
> This patch backport HADOOP-8469 and HADOOP-8470 to branch-1 and includes:
> 1. Make NetworkTopology class pluggable for extension.
> 2. Implement a 4-layer NetworkTopology class (named as NetworkTopologyWithNodeGroup) to use in virtualized environment (or other situation with additional layer between host and rack).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira