[GitHub] sven-lange-last commented on a change in pull request #4255: Improve container factory documentation

[GitBox <gi...@apache.org>]

sven-lange-last commented on a change in pull request #4255: Improve container factory documentation
URL: https://github.com/apache/incubator-openwhisk/pull/4255#discussion_r254687309
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerFactory.scala
 ##########
 @@ -52,7 +52,23 @@ case class ContainerPoolConfig(userMemory: ByteSize, concurrentPeekFactor: Doubl
  */
 trait ContainerFactory {
 
-  /** create a new Container */
+  /**
+   * Create a new Container
+   *
+   * The created container has to satisfy following requirements:
+   * - The container's file system is based on the provided action image and has a read/write layer on top.
 
 Review comment:
   @markusthoemmes I guess you talk about the read/write layer on top? Without that layer, not a single change can be made to existing files / directories and nothing new can be created.
   
   I guess most managed runtime images require creation of new files. And I think that blackbox image authors also expect that they can create files when initialising / running the action.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services