[jira] [Commented] (OLINGO-897) Cannot filter on derived properties - startTypeFilter in MemberImpl is ignored

["Christian Amend (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OLINGO-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195413#comment-15195413 ] 

Christian Amend commented on OLINGO-897:
----------------------------------------

Thanks a lot for the patch. I like the solution as it gives full access to the member which is something we missed before.

[~rareddy] and [~mirbo] are you OK with this API change? I see no other way to achieve this without this change and it has been a bug in previous versions. 

> Cannot filter on derived properties - startTypeFilter in MemberImpl is ignored
> ------------------------------------------------------------------------------
>
>                 Key: OLINGO-897
>                 URL: https://issues.apache.org/jira/browse/OLINGO-897
>             Project: Olingo
>          Issue Type: Bug
>          Components: odata4-server
>    Affects Versions: (Java) V4 4.2.0
>            Reporter: Jacek Sputowski
>            Assignee: Christian Amend
>            Priority: Critical
>         Attachments: 0001-OLINGO-897-Cannot-filter-on-derived-properties-start.patch
>
>
> According to [Addressing Derived Types|http://docs.oasis-open.org/odata/odata/v4.0/cs01/part2-url-conventions/odata-v4.0-cs01-part2-url-conventions.html#_Toc365046429] user should be able to filter on derived field
> Example: 
> http://host/service/Customers?$filter=Model.VipCustomer/PercentageOfVipPromotionProductsOrdered gt 80
> Information about type (e.g. Model.VipCustomer) is stored in field *startTypeFilter*(in MemberImpl), but it is not passed to ExpressionVisitor in *accept* method. ExpressionVisitor get only path. startTypeFilter is ignored, so it can't be used in *visitMember* method.
> Suggested changes - patch in attachment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)