[GitHub] anirudh2290 opened a new pull request #11366: [WIP] Fix flaky test:test_sample_multinomial

[GitBox <gi...@apache.org>]

anirudh2290 opened a new pull request #11366: [WIP] Fix flaky test:test_sample_multinomial
URL: https://github.com/apache/incubator-mxnet/pull/11366
 
 
   ## Description ##
   
   The test used to run 5000 experiments and obtain samples from `random.multinomial` op for this experiment. It used to make a count of the number of samples of each value (in input) and divide it by total samples to obtain the probability. This computed probability is then compared to the actual probability that is provided to the op. To make this test completely non flaky we would have to run the experiments infinite number of times. To allievate the pain caused by flakiness of this test for now, I have increased the number of samples to 10k, increased atol to 0.1 and also added a retry for the test if it fails. Hopefully, these three actions should reduce the flakiness of the test by a huge extent. I tested for 2000 runs on my machine without failure.
   
   @hjjn @asitstands 
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services