You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2023/01/11 08:43:18 UTC
[GitHub] [james-project] quantranhong1999 opened a new pull request, #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source
quantranhong1999 opened a new pull request, #1388:
URL: https://github.com/apache/james-project/pull/1388
Instead of two sources with the same truth (https://github.com/linagora/james-project/issues/4673).
(`sessionProvider.authenticate(session.getUser).as(targetUser)` called the 2nd source `authorized users`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa closed pull request #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source
Posted by GitBox <gi...@apache.org>.
chibenwa closed pull request #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source
URL: https://github.com/apache/james-project/pull/1388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on pull request #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source
Posted by GitBox <gi...@apache.org>.
quantranhong1999 commented on PR #1388:
URL: https://github.com/apache/james-project/pull/1388#issuecomment-1383462694
> Ok, just I would need it for some other topics.
For you: https://github.com/quantranhong1999/james-project/tree/rebase-poc-session-translator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on pull request #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source
Posted by GitBox <gi...@apache.org>.
quantranhong1999 commented on PR #1388:
URL: https://github.com/apache/james-project/pull/1388#issuecomment-1383442939
> (I will do)
I can do it, no worry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source
Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #1388:
URL: https://github.com/apache/james-project/pull/1388#issuecomment-1383446688
Ok, just I would need it for some other topics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source
Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #1388:
URL: https://github.com/apache/james-project/pull/1388#issuecomment-1383417966
TODO rebase https://github.com/chibenwa/james-project/tree/poc-refacto-delegation
(I will do)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source
Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #1388:
URL: https://github.com/apache/james-project/pull/1388#issuecomment-1378571262
I have two major issues wit this design:
- 1. the naming suck (): too long, not precise
- 2. with this change SessionProvider exposes the APIs to bypass its own role pushing validation logics to the applicative layers, which is unsafe and breaks encapsulation.
- 3. Too much methods does (almost) the same things.
3 big code smells ...
Especially on authorization I want to be able to review code and state "that's fine, it only relies on the session provider, so I know authorization logic won't be messed up". With this change I cannot make such assumptions.
As an alternative I would try to refine the SessionOrovider API to make it more composable and expressive while keeping it concise and safe.
Please see https://github.com/chibenwa/james-project/tree/poc-refacto-delegation as a possible alternative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org