[GitHub] [airflow] potiuk edited a comment on pull request #10892: Proposal: remove -serviceaccount suffix from KSA names in helm chart

[GitBox <gi...@apache.org>]

potiuk edited a comment on pull request #10892:
URL: https://github.com/apache/airflow/pull/10892#issuecomment-691448055


   > I'm okay with this change; are there any adverse effects when upgrading from before to after?
   
   There are known problems with Helm Updating various resources in Kubernetes. Particularly Service Account name upgrade will not work it seems https://github.com/helm/helm/issues/5473  and https://github.com/helm/helm/issues/4429 
   
   Seems there is an open "umbrella" issue to make this work for different kinds of resources that helm manages in Kubernetes: https://github.com/helm/helm/issues/5915 
   
   If we had the chart released - that would be a breaking change.  I'd say definitely when we release it, we should have a separate chart/UPDATING.md or smth, and this change should be explained there IMHO. But for now we do not even have a version that we can refer to as "when it changed" :). So the question is - do we want to start keeping track of those and other similar changes already or do we start after releasing it for the first time?
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org