You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Luca Burgazzoli (JIRA)" <ji...@apache.org> on 2019/07/01 07:12:00 UTC

[jira] [Comment Edited] (CAMEL-13704) Add github pull request template for PR instruction

    [ https://issues.apache.org/jira/browse/CAMEL-13704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875980#comment-16875980 ] 

Luca Burgazzoli edited comment on CAMEL-13704 at 7/1/19 7:11 AM:
-----------------------------------------------------------------

A commend about "Make sure there is a [JIRA issue]" : I would rework it as for camel-k and camel-quarkus we have activated github issues so a JIRA issue is not required (the subsequent requirement need to be amended as well)


was (Author: lb):
A commend about "Make sure there is a [JIRA issue]" : I would rework it as for camel-k and camel-quarkus we have activated github issues so a JIRA issue is not required

> Add github pull request template for PR instruction
> ---------------------------------------------------
>
>                 Key: CAMEL-13704
>                 URL: https://issues.apache.org/jira/browse/CAMEL-13704
>             Project: Camel
>          Issue Type: Task
>            Reporter: Willem Jiang
>            Priority: Major
>
> It's standard procedure to accept the big contribution with iCLA granted in ASF.
> We should list this information when the contributor send the PR by specifying a PR template for github.  It could be annoying for the experienced contributors, but it could save us some time for the new contributors. 
> Here is a draft I have, please add comment for it.
> {code}
>  - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
>  - [ ] Each commit in the pull request should have a meaningful subject line and body.
>  - [ ] Format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
>  - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
>  - [ ] Run `mvn clean install` in your module to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
>  - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)