You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Giridharan Kesavan (JIRA)" <ji...@apache.org> on 2009/01/22 05:21:59 UTC
[jira] Created: (HADOOP-5101) optimizing build.xml target
dependencies
optimizing build.xml target dependencies
----------------------------------------
Key: HADOOP-5101
URL: https://issues.apache.org/jira/browse/HADOOP-5101
Project: Hadoop Core
Issue Type: Improvement
Components: build
Reporter: Giridharan Kesavan
Assignee: Giridharan Kesavan
Need to optimize build.xml
For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
Likewise different targets could be optimized.
Thanks,
Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5101) optimizing build.xml target
dependencies
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666076#action_12666076 ]
Giridharan Kesavan commented on HADOOP-5101:
--------------------------------------------
This optimization will only touch the more generalized targets like the releaseaudit and findbugs. This may not have impacts on the project split
-Giri
> optimizing build.xml target dependencies
> ----------------------------------------
>
> Key: HADOOP-5101
> URL: https://issues.apache.org/jira/browse/HADOOP-5101
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
>
> Need to optimize build.xml
> For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
> Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
> Likewise different targets could be optimized.
> Thanks,
> Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5101) optimizing build.xml target
dependencies
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated HADOOP-5101:
---------------------------------------
Attachment: hadoop-5101-v1.patch
> optimizing build.xml target dependencies
> ----------------------------------------
>
> Key: HADOOP-5101
> URL: https://issues.apache.org/jira/browse/HADOOP-5101
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hadoop-5101-v1.patch, hadoop-5101.patch
>
>
> Need to optimize build.xml
> For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
> Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
> Likewise different targets could be optimized.
> Thanks,
> Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5101) optimizing build.xml target
dependencies
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-5101:
--------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
+1. Thanks Giri. Marking 'patch available'
> optimizing build.xml target dependencies
> ----------------------------------------
>
> Key: HADOOP-5101
> URL: https://issues.apache.org/jira/browse/HADOOP-5101
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hadoop-5101-v1.patch, hadoop-5101.patch
>
>
> Need to optimize build.xml
> For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
> Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
> Likewise different targets could be optimized.
> Thanks,
> Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5101) optimizing build.xml target
dependencies
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5101:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
Status: Resolved (was: Patch Available)
I committed this. Thanks, Giri
> optimizing build.xml target dependencies
> ----------------------------------------
>
> Key: HADOOP-5101
> URL: https://issues.apache.org/jira/browse/HADOOP-5101
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 0.21.0
>
> Attachments: hadoop-5101-v1.patch, hadoop-5101.patch
>
>
> Need to optimize build.xml
> For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
> Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
> Likewise different targets could be optimized.
> Thanks,
> Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5101) optimizing build.xml target
dependencies
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666062#action_12666062 ]
Sharad Agarwal commented on HADOOP-5101:
----------------------------------------
We would soon have to split the build.xml for different sub-projects - core, hdfs and mapred. So it might be better to do this optimization at that point.
> optimizing build.xml target dependencies
> ----------------------------------------
>
> Key: HADOOP-5101
> URL: https://issues.apache.org/jira/browse/HADOOP-5101
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
>
> Need to optimize build.xml
> For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
> Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
> Likewise different targets could be optimized.
> Thanks,
> Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5101) optimizing build.xml target
dependencies
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated HADOOP-5101:
---------------------------------------
Attachment: hadoop-5101-v1.patch
This patch incorporates Nigel's comments
> optimizing build.xml target dependencies
> ----------------------------------------
>
> Key: HADOOP-5101
> URL: https://issues.apache.org/jira/browse/HADOOP-5101
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hadoop-5101-v1.patch, hadoop-5101.patch
>
>
> Need to optimize build.xml
> For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
> Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
> Likewise different targets could be optimized.
> Thanks,
> Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5101) optimizing build.xml target
dependencies
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673990#action_12673990 ]
Hudson commented on HADOOP-5101:
--------------------------------
Integrated in Hadoop-trunk #756 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/])
> optimizing build.xml target dependencies
> ----------------------------------------
>
> Key: HADOOP-5101
> URL: https://issues.apache.org/jira/browse/HADOOP-5101
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 0.21.0
>
> Attachments: hadoop-5101-v1.patch, hadoop-5101.patch
>
>
> Need to optimize build.xml
> For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
> Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
> Likewise different targets could be optimized.
> Thanks,
> Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5101) optimizing build.xml target
dependencies
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668120#action_12668120 ]
Nigel Daley commented on HADOOP-5101:
-------------------------------------
Test failures are unrelated to this build patch. No tests included since this is a build file fix.
> optimizing build.xml target dependencies
> ----------------------------------------
>
> Key: HADOOP-5101
> URL: https://issues.apache.org/jira/browse/HADOOP-5101
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hadoop-5101-v1.patch, hadoop-5101.patch
>
>
> Need to optimize build.xml
> For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
> Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
> Likewise different targets could be optimized.
> Thanks,
> Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5101) optimizing build.xml target
dependencies
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666071#action_12666071 ]
Sharad Agarwal commented on HADOOP-5101:
----------------------------------------
bq. I think it makes more sense to clean up the dependencies now, then it won't have to be repeated 3 times when the project is split.
I am fine with doing it now. Just I wanted to point out that splitting is going to happen soon so we do not do much rework.
> optimizing build.xml target dependencies
> ----------------------------------------
>
> Key: HADOOP-5101
> URL: https://issues.apache.org/jira/browse/HADOOP-5101
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
>
> Need to optimize build.xml
> For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
> Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
> Likewise different targets could be optimized.
> Thanks,
> Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5101) optimizing build.xml target
dependencies
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668043#action_12668043 ]
Hadoop QA commented on HADOOP-5101:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12398806/hadoop-5101-v1.patch
against trunk revision 738329.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3765/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3765/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3765/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3765/console
This message is automatically generated.
> optimizing build.xml target dependencies
> ----------------------------------------
>
> Key: HADOOP-5101
> URL: https://issues.apache.org/jira/browse/HADOOP-5101
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hadoop-5101-v1.patch, hadoop-5101.patch
>
>
> Need to optimize build.xml
> For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
> Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
> Likewise different targets could be optimized.
> Thanks,
> Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5101) optimizing build.xml target
dependencies
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated HADOOP-5101:
---------------------------------------
Attachment: hadoop-5101.patch
This patch optimizes the findbugs targets, by calling only the required dependencies
-Giri
> optimizing build.xml target dependencies
> ----------------------------------------
>
> Key: HADOOP-5101
> URL: https://issues.apache.org/jira/browse/HADOOP-5101
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hadoop-5101.patch
>
>
> Need to optimize build.xml
> For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
> Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
> Likewise different targets could be optimized.
> Thanks,
> Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5101) optimizing build.xml target
dependencies
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666063#action_12666063 ]
Nigel Daley commented on HADOOP-5101:
-------------------------------------
I think it makes more sense to clean up the dependencies now, then it won't have to be repeated 3 times when the project is split.
> optimizing build.xml target dependencies
> ----------------------------------------
>
> Key: HADOOP-5101
> URL: https://issues.apache.org/jira/browse/HADOOP-5101
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
>
> Need to optimize build.xml
> For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
> Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
> Likewise different targets could be optimized.
> Thanks,
> Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5101) optimizing build.xml target
dependencies
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666262#action_12666262 ]
Nigel Daley commented on HADOOP-5101:
-------------------------------------
Can we also combine test-c++-libhdfs target into the test target? Seems like test-c++-libhdfs will only be run if -Dlibhdfs=1 is set, right? So that should be safe.
> optimizing build.xml target dependencies
> ----------------------------------------
>
> Key: HADOOP-5101
> URL: https://issues.apache.org/jira/browse/HADOOP-5101
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hadoop-5101.patch
>
>
> Need to optimize build.xml
> For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
> Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
> Likewise different targets could be optimized.
> Thanks,
> Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5101) optimizing build.xml target
dependencies
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated HADOOP-5101:
---------------------------------------
Attachment: (was: hadoop-5101-v1.patch)
> optimizing build.xml target dependencies
> ----------------------------------------
>
> Key: HADOOP-5101
> URL: https://issues.apache.org/jira/browse/HADOOP-5101
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hadoop-5101-v1.patch, hadoop-5101.patch
>
>
> Need to optimize build.xml
> For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
> Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples
> Likewise different targets could be optimized.
> Thanks,
> Giri
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.