[jira] [Commented] (TC-345) source tarball has invalid link

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TC-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017790#comment-16017790 ] 

ASF GitHub Bot commented on TC-345:
-----------------------------------

GitHub user dangogh opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/591

    [TC-345] when creating tarball, do not transform symlinks

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dangogh/incubator-trafficcontrol fix/tarball-link

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/591.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #591
    
----
commit 99f5e005861dc85f05b04dba11e3398e4bf115ed
Author: Dan Kirkwood <da...@gmail.com>
Date:   2017-05-19T18:20:41Z

    when creating tarball, do not transform symlinks

----


> source tarball has invalid link
> -------------------------------
>
>                 Key: TC-345
>                 URL: https://issues.apache.org/jira/browse/TC-345
>             Project: Traffic Control
>          Issue Type: Bug
>          Components: Release
>    Affects Versions: 2.0.0, 2.1.0
>            Reporter: Dan Kirkwood
>            Assignee: Dan Kirkwood
>            Priority: Blocker
>              Labels: easyfix
>             Fix For: 2.0.0, 2.1.0
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> There's a symlink in the repo: 
> traffic_stats/vendor/github.com/apache/incubator-trafficcontrol/traffic_ops/client -> ../../../../../../traffic_ops/client
> When the tarball is created,  it uses tar's `--transform` option which breaks that symlink.   Fix is trivial,  but needs to be backported to 2.0.x because it will break anyone trying to build traffic_stats from the tarball.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)