[GitHub] [incubator-tvm] u99127 commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added

[GitBox <gi...@apache.org>]

u99127 commented on a change in pull request #4788: [FRONTEND][TFLITE]Gather, StridedSlice op support added
URL: https://github.com/apache/incubator-tvm/pull/4788#discussion_r372389879
 
 

 ##########
 File path: python/tvm/relay/frontend/tflite.py
 ##########
 @@ -747,6 +749,158 @@ def convert_squared_difference(self, op):
         out = _op.power(difference, relay.const(2, exp_type))
         return out
 
+    def convert_gather(self, op):
+        """Method to Convert TFLite Gather operator"""
+        # Check if the input tensor is quantized, call QNN op
+        if self.is_quantized(op):
+            raise tvm.error.OpNotImplemented(
+                'TFlite quantized gather operator is not supported yet.')
 
 Review comment:
   Since this is a tensor manipulation operation rather than something that requires any specific qnn dialect, I would prefer we handle the qnn ops here. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services