[GitHub] [iceberg] jackye1995 commented on a change in pull request #2267: AWS: do not list non-iceberg table in Glue

[GitBox <gi...@apache.org>]

jackye1995 commented on a change in pull request #2267:
URL: https://github.com/apache/iceberg/pull/2267#discussion_r582339164



##########
File path: aws/src/test/java/org/apache/iceberg/aws/glue/GlueCatalogTest.java
##########
@@ -316,8 +347,11 @@ public void dropNamespace() {
   public void dropNamespace_notEmpty() {
     Mockito.doReturn(GetTablesResponse.builder()
         .tableList(
-            Table.builder().databaseName("db1").name("t1").build(),
-            Table.builder().databaseName("db1").name("t2").build()
+            Table.builder().databaseName("db1").name("t1").parameters(
+                ImmutableMap.of(
+                    BaseMetastoreTableOperations.TABLE_TYPE_PROP, BaseMetastoreTableOperations.ICEBERG_TABLE_TYPE_VALUE

Review comment:
       Great catch, dropping namespace with non-empty non-Iceberg table is interesting, in theory Iceberg should not care about it, but in practice we should probably not delete the namespace. So I updated the logic to check for iceberg or non-iceberg tables, and throw exception with different message for different cases. I have updated both the unit test and also the integration test.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org