You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Eric Shu (JIRA)" <ji...@apache.org> on 2019/03/01 23:47:00 UTC

[jira] [Created] (GEODE-6478) getInitialImageAndRecovery method should check cancelException when trying get gii during initializing

Eric Shu created GEODE-6478:
-------------------------------

             Summary: getInitialImageAndRecovery method should check cancelException when trying get gii during initializing
                 Key: GEODE-6478
                 URL: https://issues.apache.org/jira/browse/GEODE-6478
             Project: Geode
          Issue Type: Bug
          Components: regions
            Reporter: Eric Shu


When trying to fix GEODE-6477, I find out getInitialImageAndRecovery() continue in the loop to get gii from another data source.
This continues even in shutdown all case, which means no data source would be available for gii. I think it should check CancelException and give up - as shutdown all would shut down the requester as well.

The code does the loop and continues if getFromOne could not get gii from others.
    boolean done = false;
    while (!done && !isDestroyed()) { 
    ...
           GIIStatus ret =
              iiop.getFromOne(advice.replicates, false, advice, recoverFromDisk, recovered_rvv);
          if (GIIStatus.didGII(ret)) {
            cleanUpDestroyedTokensAndMarkGIIComplete(ret);
            done = true;
            return;
          }
}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)