You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Tobias Soloschenko <to...@googlemail.com> on 2016/08/27 16:10:28 UTC

Fwd: [jira] [Commented] (WICKET-6194) PushBuilder API integration

Anyone who was able to review the last commit, yet?

I also double checked the caching implementation and with this a request is done all the time to the main page but the caching header is send which is important for the push behavior. I added a comment to the ticket.

https://issues.apache.org/jira/browse/WICKET-6194

I would be very pleased if someone is able to try it out and give me feedback. :-)

kind regards

Tobias

Anfang der weitergeleiteten E‑Mail:

> Von: "ASF subversion and git services (JIRA)" <ji...@apache.org>
> Datum: 18. August 2016 um 21:51:21 MESZ
> An: tobias.soloschenko@googlemail.com
> Betreff: [jira] [Commented] (WICKET-6194) PushBuilder API integration
> 
> 
>    [ https://issues.apache.org/jira/browse/WICKET-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427046#comment-15427046 ] 
> 
> ASF subversion and git services commented on WICKET-6194:
> ---------------------------------------------------------
> 
> Commit 94cea576b67f1e55e2accc1caa22eddf04225b40 in wicket's branch refs/heads/master from [~klopfdreh]
> [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=94cea57 ]
> 
> WICKET-6194 concurrency fix / cache handling / doc
> 
> 
>> PushBuilder API integration
>> ---------------------------
>> 
>>                Key: WICKET-6194
>>                URL: https://issues.apache.org/jira/browse/WICKET-6194
>>            Project: Wicket
>>         Issue Type: New Feature
>>   Affects Versions: 8.0.0-M1
>>           Reporter: Tobias Soloschenko
>>           Assignee: Tobias Soloschenko
>>             Labels: features
>>            Fix For: 8.0.0-M2
>> 
>> 
>> Allows to push resources via HeaderItem to the client and make use of the http/2 functionality. In the first step this should be an experimental module and make use of the server specific APIs until the servlet 4.0 standard is finished.
>> A reference implementation can be found here: 
>> https://github.com/klopfdreh/wicket-components-playground/wiki/23.-PushHeaderItem_Servlet4Support
>> Working-Branch:
>> https://github.com/apache/wicket/tree/WICKET-6194
> 
> 
> 
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)

Re: [jira] [Commented] (WICKET-6194) PushBuilder API integration

Posted by Tobias Soloschenko <to...@googlemail.com>.
Hi Martin,

I am also not happy that the caching by default only checks the markup (it is like in JSP) - but I currently don't see any other options.

kind regards

Tobias

> Am 07.10.2016 um 21:54 schrieb Martin Grigorov <mg...@apache.org>:
> 
> Hi Tobias,
> 
> I've just tested org.apache.wicket.http2.markup.head.Tomcat85PushBuilder
> with Tomcat 8.5.6 (currently being voted).
> I've found a small bug.
> Now it works like a charm!
> 
> I'm still not very happy with the hacks needed for the caching but this is
> different story :-)
> 
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
> 
> On Sat, Aug 27, 2016 at 6:10 PM, Tobias Soloschenko <
> tobiassoloschenko@googlemail.com> wrote:
> 
>> Anyone who was able to review the last commit, yet?
>> 
>> I also double checked the caching implementation and with this a request
>> is done all the time to the main page but the caching header is send which
>> is important for the push behavior. I added a comment to the ticket.
>> 
>> https://issues.apache.org/jira/browse/WICKET-6194
>> 
>> I would be very pleased if someone is able to try it out and give me
>> feedback. :-)
>> 
>> kind regards
>> 
>> Tobias
>> 
>> Anfang der weitergeleiteten E‑Mail:
>> 
>>> Von: "ASF subversion and git services (JIRA)" <ji...@apache.org>
>>> Datum: 18. August 2016 um 21:51:21 MESZ
>>> An: tobias.soloschenko@googlemail.com
>>> Betreff: [jira] [Commented] (WICKET-6194) PushBuilder API integration
>>> 
>>> 
>>>   [ https://issues.apache.org/jira/browse/WICKET-6194?page=
>> com.atlassian.jira.plugin.system.issuetabpanels:comment-
>> tabpanel&focusedCommentId=15427046#comment-15427046 ]
>>> 
>>> ASF subversion and git services commented on WICKET-6194:
>>> ---------------------------------------------------------
>>> 
>>> Commit 94cea576b67f1e55e2accc1caa22eddf04225b40 in wicket's branch
>> refs/heads/master from [~klopfdreh]
>>> [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=94cea57 ]
>>> 
>>> WICKET-6194 concurrency fix / cache handling / doc
>>> 
>>> 
>>>> PushBuilder API integration
>>>> ---------------------------
>>>> 
>>>>               Key: WICKET-6194
>>>>               URL: https://issues.apache.org/jira/browse/WICKET-6194
>>>>           Project: Wicket
>>>>        Issue Type: New Feature
>>>>  Affects Versions: 8.0.0-M1
>>>>          Reporter: Tobias Soloschenko
>>>>          Assignee: Tobias Soloschenko
>>>>            Labels: features
>>>>           Fix For: 8.0.0-M2
>>>> 
>>>> 
>>>> Allows to push resources via HeaderItem to the client and make use of
>> the http/2 functionality. In the first step this should be an experimental
>> module and make use of the server specific APIs until the servlet 4.0
>> standard is finished.
>>>> A reference implementation can be found here:
>>>> https://github.com/klopfdreh/wicket-components-playground/
>> wiki/23.-PushHeaderItem_Servlet4Support
>>>> Working-Branch:
>>>> https://github.com/apache/wicket/tree/WICKET-6194
>>> 
>>> 
>>> 
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.3.4#6332)
>> 

Re: [jira] [Commented] (WICKET-6194) PushBuilder API integration

Posted by Martin Grigorov <mg...@apache.org>.
Hi Tobias,

I've just tested org.apache.wicket.http2.markup.head.Tomcat85PushBuilder
with Tomcat 8.5.6 (currently being voted).
I've found a small bug.
Now it works like a charm!

I'm still not very happy with the hacks needed for the caching but this is
different story :-)

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Sat, Aug 27, 2016 at 6:10 PM, Tobias Soloschenko <
tobiassoloschenko@googlemail.com> wrote:

> Anyone who was able to review the last commit, yet?
>
> I also double checked the caching implementation and with this a request
> is done all the time to the main page but the caching header is send which
> is important for the push behavior. I added a comment to the ticket.
>
> https://issues.apache.org/jira/browse/WICKET-6194
>
> I would be very pleased if someone is able to try it out and give me
> feedback. :-)
>
> kind regards
>
> Tobias
>
> Anfang der weitergeleiteten E‑Mail:
>
> > Von: "ASF subversion and git services (JIRA)" <ji...@apache.org>
> > Datum: 18. August 2016 um 21:51:21 MESZ
> > An: tobias.soloschenko@googlemail.com
> > Betreff: [jira] [Commented] (WICKET-6194) PushBuilder API integration
> >
> >
> >    [ https://issues.apache.org/jira/browse/WICKET-6194?page=
> com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel&focusedCommentId=15427046#comment-15427046 ]
> >
> > ASF subversion and git services commented on WICKET-6194:
> > ---------------------------------------------------------
> >
> > Commit 94cea576b67f1e55e2accc1caa22eddf04225b40 in wicket's branch
> refs/heads/master from [~klopfdreh]
> > [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=94cea57 ]
> >
> > WICKET-6194 concurrency fix / cache handling / doc
> >
> >
> >> PushBuilder API integration
> >> ---------------------------
> >>
> >>                Key: WICKET-6194
> >>                URL: https://issues.apache.org/jira/browse/WICKET-6194
> >>            Project: Wicket
> >>         Issue Type: New Feature
> >>   Affects Versions: 8.0.0-M1
> >>           Reporter: Tobias Soloschenko
> >>           Assignee: Tobias Soloschenko
> >>             Labels: features
> >>            Fix For: 8.0.0-M2
> >>
> >>
> >> Allows to push resources via HeaderItem to the client and make use of
> the http/2 functionality. In the first step this should be an experimental
> module and make use of the server specific APIs until the servlet 4.0
> standard is finished.
> >> A reference implementation can be found here:
> >> https://github.com/klopfdreh/wicket-components-playground/
> wiki/23.-PushHeaderItem_Servlet4Support
> >> Working-Branch:
> >> https://github.com/apache/wicket/tree/WICKET-6194
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v6.3.4#6332)
>