You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Charan Reddy G <re...@gmail.com> on 2017/07/18 08:23:24 UTC

BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile testcase broken

Hey Sijie,

It looks like one of your commit -
https://github.com/reddycharan/bookkeeper/commit/c49621bacaa960d240afbbee83a9703b4cbc3ec2
broke BookieInitializationTest.
testWithDiskFullAndAbilityToCreateNewIndexFile testcase. Can you please
check that.

Thanks,
Charan

Re: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile testcase broken

Posted by Charan Reddy G <re...@gmail.com>.
+1 LGTM.

THanks,
CHaran

On Tue, Jul 18, 2017 at 10:43 AM, Sijie Guo <gu...@gmail.com> wrote:

> Charan,
>
> Here is the pull request to address the problem: https://github.com/
> apache/bookkeeper/pull/257
>
> - Sijie
>
> On Wed, Jul 19, 2017 at 12:49 AM, Sijie Guo <gu...@gmail.com> wrote:
>
>> Sure.
>>
>> I was looking into that last night as well. I will work on that.
>>
>> - Sijie
>>
>> On Tue, Jul 18, 2017 at 4:23 PM, Charan Reddy G <re...@gmail.com>
>> wrote:
>>
>>> Hey Sijie,
>>>
>>> It looks like one of your commit -https://github.com/reddychara
>>> n/bookkeeper/commit/c49621bacaa960d240afbbee83a9703b4cbc3ec2 broke
>>> BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile testcase.
>>> Can you please check that.
>>>
>>> Thanks,
>>> Charan
>>>
>>
>>
>

Re: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile testcase broken

Posted by Sijie Guo <gu...@gmail.com>.
Charan,

Here is the pull request to address the problem:
https://github.com/apache/bookkeeper/pull/257

- Sijie

On Wed, Jul 19, 2017 at 12:49 AM, Sijie Guo <gu...@gmail.com> wrote:

> Sure.
>
> I was looking into that last night as well. I will work on that.
>
> - Sijie
>
> On Tue, Jul 18, 2017 at 4:23 PM, Charan Reddy G <re...@gmail.com>
> wrote:
>
>> Hey Sijie,
>>
>> It looks like one of your commit -https://github.com/reddychara
>> n/bookkeeper/commit/c49621bacaa960d240afbbee83a9703b4cbc3ec2 broke
>> BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile testcase.
>> Can you please check that.
>>
>> Thanks,
>> Charan
>>
>
>

Re: BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile testcase broken

Posted by Sijie Guo <gu...@gmail.com>.
Sure.

I was looking into that last night as well. I will work on that.

- Sijie

On Tue, Jul 18, 2017 at 4:23 PM, Charan Reddy G <re...@gmail.com>
wrote:

> Hey Sijie,
>
> It looks like one of your commit -https://github.com/
> reddycharan/bookkeeper/commit/c49621bacaa960d240afbbee83a9703b4cbc3ec2
> broke BookieInitializationTest.testWithDiskFullAndAbilityToC
> reateNewIndexFile testcase. Can you please check that.
>
> Thanks,
> Charan
>