You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/31 07:16:11 UTC
[GitHub] [kafka] cadonna opened a new pull request, #12573: KAFKA-10199: Remove changelog unregister from state updater
cadonna opened a new pull request, #12573:
URL: https://github.com/apache/kafka/pull/12573
Changelogs are already unregistered when tasks are closed.
There is no need to also unregister them in the state
updater.
In future, when we will only have the state updater without
the old code path, we should consider registering and
unregistering the changelogs within the state updater.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12573: KAFKA-10199: Remove changelog unregister from state updater
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12573:
URL: https://github.com/apache/kafka/pull/12573#issuecomment-1232554297
Call for review: @wcarlson5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #12573: KAFKA-10199: Remove changelog unregister from state updater
Posted by GitBox <gi...@apache.org>.
cadonna merged PR #12573:
URL: https://github.com/apache/kafka/pull/12573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12573: KAFKA-10199: Remove changelog unregister from state updater
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12573:
URL: https://github.com/apache/kafka/pull/12573#issuecomment-1234212740
Build failures are not related:
```
Build / JDK 11 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()
Build / JDK 17 and Scala 2.13 / kafka.api.SaslClientsWithInvalidCredentialsTest.testManualAssignmentConsumerWithAutoCommitDisabledWithAuthenticationFailure()
Build / JDK 17 and Scala 2.13 / kafka.api.TransactionsTest.testCommitTransactionTimeout(String).quorum=kraft
Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore[exactly_once_v2]
Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.EosIntegrationTest.shouldBeAbleToRunWithTwoSubtopologies[at_least_once]
Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.EosIntegrationTest.shouldWriteLatestOffsetsToCheckpointOnShutdown[at_least_once]
Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.KStreamRepartitionIntegrationTest.shouldGoThroughRebalancingCorrectly[Optimization = all]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org