You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/04/04 19:42:16 UTC

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #6718: Have the asf-ci user create Pull Requests for GitHub Actions

zrhoffman opened a new pull request, #6718:
URL: https://github.com/apache/trafficcontrol/pull/6718

   <!--
   Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
   If this closes or relates to an existing issue, please reference it using one of the following:
   
   Closes: #ISSUE
   Related: #ISSUE
   
   If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://apache.org/security regarding vulnerability disclosure.
   -->
   
   This PR makes Pull Requests created by our GitHub Actions use an API token created by the @asf-ci account (secret or the token requested in [INFRA-23048](https://issues.apache.org/jira/browse/INFRA-23048)). This makes our GitHub Actions actually run on these GHA-created PRs, since PRs authored by the **[@apps/github-actions](https://github.com/apps/github-actions)** user do not trigger any GHAs. The branches and commits are still built using the token from **[@apps/github-actions](https://github.com/apps/github-actions)**.
   <!-- **^ Add meaningful description above** --><hr/>
   
   ## Which Traffic Control components are affected by this PR?
   <!-- Please delete all components from this list that are NOT affected by this PR.
   Feel free to add the name of a tool or script that is affected but not on the list.
   -->
   - Automation - GitHub Actions<!-- Please specify which (GitHub Actions, Docker images, Ansible Roles, etc.) -->
   
   ## What is the best way to verify this PR?
   <!-- Please include here ALL the steps necessary to test your PR.
   If your PR has tests (and most should), provide the steps needed to run the tests.
   If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
   1. Push the [`zrhoffman:asf-ci-token`](https://github.com/zrhoffman/trafficcontrol/commits/asf-ci-token) to the `master` branch of your own fork
   2. Cherry-pick 162af3f2bd onto the `master` branch of your fork, which downgrades the Go version to 1.17.7
   3. Go to https://github.com/settings/tokens
   4. Generate a token then has the *public_repo* scope enabled
   5. https://github.com/<Your Username\>/trafficcontrol/settings/secrets/actions
   6. Create a new Repository Secret named `ASFCI_TOKEN` which contains that token
   7. Manually trigger forkflow runs:
      - https://github.com/<Your Username\>/trafficcontrol/actions/workflows/assign-triage-role.yml
      - https://github.com/<Your Username\>/trafficcontrol/actions/workflows/pr-to-update-go.yml
   8. Go to https://github.com/<Your Username\>/trafficcontrol/pulls and verify that the generated PRs are authored by you, not GitHub Actions
   
   ## PR submission checklist
   - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
   - [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
   - [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] ocket8888 merged pull request #6718: Have the asf-ci user create Pull Requests for GitHub Actions

Posted by GitBox <gi...@apache.org>.
ocket8888 merged PR #6718:
URL: https://github.com/apache/trafficcontrol/pull/6718


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org