You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by Dan S <ds...@gmail.com> on 2022/09/29 15:35:38 UTC
Git questions for supplying a contribution
Based on ContributorGuide-Cloneacopyoftherepository
<https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-Cloneacopyoftherepository>I
had initially run
git clone https://github.com/apache/nifi.git and then I believe in error I
also ran
git remote add upstream https://github.com/apache/nifi.git
Now when I run git remote -v
I have
origin https://github.com/apache/nifi.git (fetch)
origin https://github.com/apache/nifi.git (push)
upstream https://github.com/apache/nifi.git (fetch)
upstream https://github.com/apache/nifi.git (push)
The instructions on ContributorGuide-Supplyingacontribution
<https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-Supplyingacontribution>
for
a PR seem to be when the clone was from a fork (git clone
git@github.com:<account
name>/nifi.git) and from a mirror.
For my setup can I still run
git push origin <branch name> ?
Re: Git questions for supplying a contribution
Posted by Dan S <ds...@gmail.com>.
So I forked from repo in Github, cloned from the fork and then I ran
git remote add upstream https://github.com/apache/nifi.git
When I run git remote -v I get
> origin git@github.com:dan-s1/nifi.git (fetch)
> origin git@github.com:dan-s1/nifi.git (push)
> upstream https://github.com/apache/nifi.git (fetch)
> upstream https://github.com/apache/nifi.git (push)
Based on the instructions shouldn't I only have
> origin git@github.com:dan-s1/nifi.git (fetch)
> origin git@github.com:dan-s1/nifi.git (push)
> upstream https://github.com/apache/nifi.git (fetch)
On Thu, Sep 29, 2022 at 12:07 PM Bryan Bende <bb...@gmail.com> wrote:
> You would need to do the "Clone from Fork" step, having first forked
> the repo in Github.
>
> Then your "origin" would be your fork, and you can push anything you
> want to your fork.
>
> You won't have permissions to push anything to the apache repo with
> your current setup.
>
> On Thu, Sep 29, 2022 at 11:54 AM Joe Witt <jo...@gmail.com> wrote:
> >
> > Dan
> >
> > You can think of 'upstream' as your 'origin'.
> >
> > You want to add your mirror in there. You'd submit your code change
> > in a branch to your fork/mirror. And from that you'd request/submit a
> > pull request to NiFi. This is important because you wont be able to
> > commit to the apache/nifi codebase for now (but if you become a
> > committer you can - still though we all use the model I mention).
> >
> > Thanks
> >
> > On Thu, Sep 29, 2022 at 8:36 AM Dan S <ds...@gmail.com> wrote:
> > >
> > > Based on ContributorGuide-Cloneacopyoftherepository
> > > <
> https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-Cloneacopyoftherepository
> >I
> > > had initially run
> > > git clone https://github.com/apache/nifi.git and then I believe in
> error I
> > > also ran
> > > git remote add upstream https://github.com/apache/nifi.git
> > >
> > > Now when I run git remote -v
> > > I have
> > > origin https://github.com/apache/nifi.git (fetch)
> > > origin https://github.com/apache/nifi.git (push)
> > > upstream https://github.com/apache/nifi.git (fetch)
> > > upstream https://github.com/apache/nifi.git (push)
> > >
> > > The instructions on ContributorGuide-Supplyingacontribution
> > > <
> https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-Supplyingacontribution
> >
> > > for
> > > a PR seem to be when the clone was from a fork (git clone
> > > git@github.com:<account
> > > name>/nifi.git) and from a mirror.
> > >
> > > For my setup can I still run
> > >
> > > git push origin <branch name> ?
>
Re: Git questions for supplying a contribution
Posted by Bryan Bende <bb...@gmail.com>.
You would need to do the "Clone from Fork" step, having first forked
the repo in Github.
Then your "origin" would be your fork, and you can push anything you
want to your fork.
You won't have permissions to push anything to the apache repo with
your current setup.
On Thu, Sep 29, 2022 at 11:54 AM Joe Witt <jo...@gmail.com> wrote:
>
> Dan
>
> You can think of 'upstream' as your 'origin'.
>
> You want to add your mirror in there. You'd submit your code change
> in a branch to your fork/mirror. And from that you'd request/submit a
> pull request to NiFi. This is important because you wont be able to
> commit to the apache/nifi codebase for now (but if you become a
> committer you can - still though we all use the model I mention).
>
> Thanks
>
> On Thu, Sep 29, 2022 at 8:36 AM Dan S <ds...@gmail.com> wrote:
> >
> > Based on ContributorGuide-Cloneacopyoftherepository
> > <https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-Cloneacopyoftherepository>I
> > had initially run
> > git clone https://github.com/apache/nifi.git and then I believe in error I
> > also ran
> > git remote add upstream https://github.com/apache/nifi.git
> >
> > Now when I run git remote -v
> > I have
> > origin https://github.com/apache/nifi.git (fetch)
> > origin https://github.com/apache/nifi.git (push)
> > upstream https://github.com/apache/nifi.git (fetch)
> > upstream https://github.com/apache/nifi.git (push)
> >
> > The instructions on ContributorGuide-Supplyingacontribution
> > <https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-Supplyingacontribution>
> > for
> > a PR seem to be when the clone was from a fork (git clone
> > git@github.com:<account
> > name>/nifi.git) and from a mirror.
> >
> > For my setup can I still run
> >
> > git push origin <branch name> ?
Re: Git questions for supplying a contribution
Posted by Joe Witt <jo...@gmail.com>.
Dan
You can think of 'upstream' as your 'origin'.
You want to add your mirror in there. You'd submit your code change
in a branch to your fork/mirror. And from that you'd request/submit a
pull request to NiFi. This is important because you wont be able to
commit to the apache/nifi codebase for now (but if you become a
committer you can - still though we all use the model I mention).
Thanks
On Thu, Sep 29, 2022 at 8:36 AM Dan S <ds...@gmail.com> wrote:
>
> Based on ContributorGuide-Cloneacopyoftherepository
> <https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-Cloneacopyoftherepository>I
> had initially run
> git clone https://github.com/apache/nifi.git and then I believe in error I
> also ran
> git remote add upstream https://github.com/apache/nifi.git
>
> Now when I run git remote -v
> I have
> origin https://github.com/apache/nifi.git (fetch)
> origin https://github.com/apache/nifi.git (push)
> upstream https://github.com/apache/nifi.git (fetch)
> upstream https://github.com/apache/nifi.git (push)
>
> The instructions on ContributorGuide-Supplyingacontribution
> <https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-Supplyingacontribution>
> for
> a PR seem to be when the clone was from a fork (git clone
> git@github.com:<account
> name>/nifi.git) and from a mirror.
>
> For my setup can I still run
>
> git push origin <branch name> ?