You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/02/21 14:04:58 UTC
[GitHub] [arrow-nanoarrow] paleolimbot opened a new pull request, #112: fix: make sure bundled nanoarrow is also valid C++
paleolimbot opened a new pull request, #112:
URL: https://github.com/apache/arrow-nanoarrow/pull/112
Apparently it's difficult to pass different flags to C and C++ files in a Python extension. The C library was almost valid C++ anyway and because there are quite a few static inline functions, it's probably a good idea to make sure that the project compiles under a C++ compiler as well (since the nanoarrow.h header will be compiled with C++ if included in a C++ project).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot commented on pull request #112: fix: make sure bundled nanoarrow is also valid C++
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #112:
URL: https://github.com/apache/arrow-nanoarrow/pull/112#issuecomment-1438629802
That's a good point...I'm not sure I would go as far as saying that it's a good idea to do this (but it's easy enough to make it possible) 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #112: fix: make sure bundled nanoarrow is also valid C++
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #112:
URL: https://github.com/apache/arrow-nanoarrow/pull/112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org