You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/02/12 10:00:43 UTC
[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request
#734: MINIFICPP-1157 Implement lightweight C2 heartbeat.
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378143506
##########
File path: libminifi/src/FlowController.cpp
##########
@@ -931,6 +942,35 @@ int16_t FlowController::getMetricsNodes(std::vector<std::shared_ptr<state::respo
return 0;
}
+int16_t FlowController::getManifestNodes(std::vector<std::shared_ptr<state::response::ResponseNode>>& manifest_vector, uint16_t metricsClass) {
+ std::lock_guard<std::mutex> lock(metrics_mutex_);
+ (void)metricsClass;
+ for (auto metric : agent_information_) {
Review comment:
const auto& to avoid copy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services