You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/06/18 20:57:17 UTC
[GitHub] [iceberg] nastra opened a new pull request #2713: Replace LinkedList usage with ArrayDeque for better performance
nastra opened a new pull request #2713:
URL: https://github.com/apache/iceberg/pull/2713
See also https://errorprone.info/bugpattern/JdkObsolete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2713: Replace LinkedList usage with ArrayDeque for better performance
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2713:
URL: https://github.com/apache/iceberg/pull/2713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #2713: Replace LinkedList usage with ArrayDeque for better performance
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2713:
URL: https://github.com/apache/iceberg/pull/2713#discussion_r654565635
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java
##########
@@ -37,7 +37,7 @@
*/
public class TypeWithSchemaVisitor<T> {
@SuppressWarnings({"checkstyle:VisibilityModifier", "checkstyle:IllegalType"})
Review comment:
Is the checkstyle suppression still valid?
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java
##########
@@ -37,7 +37,7 @@
*/
public class TypeWithSchemaVisitor<T> {
@SuppressWarnings({"checkstyle:VisibilityModifier", "checkstyle:IllegalType"})
Review comment:
Yeah, I thought the visibility modifier one would be. But the illegal type seems like it would be no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2713: Replace LinkedList usage with ArrayDeque for better performance
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2713:
URL: https://github.com/apache/iceberg/pull/2713#issuecomment-865346058
Thanks, @nastra!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a change in pull request #2713: Replace LinkedList usage with ArrayDeque for better performance
Posted by GitBox <gi...@apache.org>.
nastra commented on a change in pull request #2713:
URL: https://github.com/apache/iceberg/pull/2713#discussion_r654603051
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java
##########
@@ -37,7 +37,7 @@
*/
public class TypeWithSchemaVisitor<T> {
@SuppressWarnings({"checkstyle:VisibilityModifier", "checkstyle:IllegalType"})
Review comment:
at least the `checkstyle:VisibilityModifier` is still valid: `TypeWithSchemaVisitor.java:39:32: Variable 'fieldNames' must be private and have accessor methods. [VisibilityModifier]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2713: Replace LinkedList usage with ArrayDeque for better performance
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2713:
URL: https://github.com/apache/iceberg/pull/2713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on pull request #2713: Replace LinkedList usage with ArrayDeque for better performance
Posted by GitBox <gi...@apache.org>.
nastra commented on pull request #2713:
URL: https://github.com/apache/iceberg/pull/2713#issuecomment-864127601
/cc @rdblue looks like this one failed because it couldn't pull `snappy-java.jar` and I can't restart CI. Would you mind restarting CI please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2713: Replace LinkedList usage with ArrayDeque for better performance
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2713:
URL: https://github.com/apache/iceberg/pull/2713#issuecomment-865346058
Thanks, @nastra!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org