[GitHub] [mesos] bmahler commented on pull request #454: Support for nvidia MIG in Mesos containerizer

["bmahler (via GitHub)" <gi...@apache.org>]

bmahler commented on PR #454:
URL: https://github.com/apache/mesos/pull/454#issuecomment-1409388019

   Hi @jblache, cool to see this getting upstreamed. A couple of suggestions:
   
   * Can you a more detailed overview of the implementation approach in the PR description? It's a bit hard to dive into reviewing this code from the current description.
   * To ease reviewing, typically we break apart patches. For example, in this PR, the nvml.hpp/cpp files can easily be their own commit for review purposes. I haven't used github PRs for reviewing stacks of commits, but I think if you just split the commits and use multiple in the PR, it should be at least reviewable in chunks, but probably not as directly committable in chunks. If you want to use reviewboard I think there is still support with ./support/post-reviews.py
   
   If others chime in here willing to review, perhaps we can organize a meeting to review more easily. I'm not active in mesos lately but would be willing to provide some feedback here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org