You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2023/05/09 08:16:48 UTC
[GitHub] [arrow] AlenkaF opened a new pull request, #35504: GH-35490: [Python] Interchange protocol: update tests for string and large_string
AlenkaF opened a new pull request, #35504:
URL: https://github.com/apache/arrow/pull/35504
### Rationale for this change
In pandas version 2.0.1 the interchange protocol implementation has support for large strings. The tests on our side need to be updated accordingly.
### What changes are included in this PR?
Changes in tests:
- `test_pandas_assertion_error_large_string` removed
- `test_roundtrip_pandas_string ` updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35504: GH-35490: [Python] Interchange protocol: update tests for string and large_string
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35504:
URL: https://github.com/apache/arrow/pull/35504#issuecomment-1541892253
Revision: 5f050276cc787c3e5e2625206bed7a3559367409
Submitted crossbow builds: [ursacomputing/crossbow @ actions-6f1dfae313](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6f1dfae313)
|Task|Status|
|----|------|
|test-conda-python-3.7-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/4935953609/jobs/8822897015)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/4935953314/jobs/8822896388)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/4935952963/jobs/8822895851)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/4935953936/jobs/8822898008)|
|test-conda-python-3.9-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/4935953778/jobs/8822897521)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #35504: GH-35490: [Python] Interchange protocol: update tests for string and large_string
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #35504:
URL: https://github.com/apache/arrow/pull/35504#issuecomment-1541888235
@github-actions crossbow submit test-conda-python-*-pandas-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35504: GH-35490: [Python] Interchange protocol: update tests for string and large_string
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35504:
URL: https://github.com/apache/arrow/pull/35504#issuecomment-1539663591
* Closes: #35490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #35504: GH-35490: [Python] Interchange protocol: update tests for string and large_string
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #35504:
URL: https://github.com/apache/arrow/pull/35504#issuecomment-1540388616
Oh yes, of course! Will correct 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35504: GH-35490: [Python] Interchange protocol: update tests for string and large_string
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35504:
URL: https://github.com/apache/arrow/pull/35504#issuecomment-1544825600
Benchmark runs are scheduled for baseline = 11780b96d5acb53c7bf753b6ab95e77e7c38bd57 and contender = dec445374cd0dd4a2fd9808bfeb7a7e0162c9e14. dec445374cd0dd4a2fd9808bfeb7a7e0162c9e14 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2b3cc1bbc89d437087d1877b6091f33e...ea8858d4710e419287df1e80d50a213d/)
[Finished :arrow_down:2.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/7595771e3cde4f4987538896f80029ea...1403d9492f8b440dbee1d83d19b829eb/)
[Finished :arrow_down:1.02% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/aff1acf29a764aa6b7168ca998eada20...5e2440a4022f4b69a299a0b1d4551575/)
[Finished :arrow_down:0.63% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6c34770ca59f48b393276980669014f1...153232e68ba348f88a4bf6aedde388f6/)
Buildkite builds:
[Finished] [`dec44537` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2851)
[Finished] [`dec44537` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2887)
[Finished] [`dec44537` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2854)
[Finished] [`dec44537` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2877)
[Finished] [`11780b96` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2850)
[Finished] [`11780b96` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2886)
[Finished] [`11780b96` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2853)
[Finished] [`11780b96` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2876)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35504: GH-35490: [Python] Interchange protocol: update tests for string and large_string
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35504:
URL: https://github.com/apache/arrow/pull/35504#issuecomment-1541835165
Revision: 0179e1c56a3d5c931728bb2fdf7ac3189af01fec
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d113313268](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d113313268)
|Task|Status|
|----|------|
|test-conda-python-3.7-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/4935627156/jobs/8822176768)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/4935627439/jobs/8822177721)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/4935627600/jobs/8822178214)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/4935627279/jobs/8822177158)|
|test-conda-python-3.9-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/4935626721/jobs/8822175814)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche merged pull request #35504: GH-35490: [Python] Interchange protocol: update tests for string and large_string
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #35504:
URL: https://github.com/apache/arrow/pull/35504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #35504: GH-35490: [Python] Interchange protocol: update tests for string and large_string
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #35504:
URL: https://github.com/apache/arrow/pull/35504#issuecomment-1543527083
> Nightly failure is unrelated (but something else we should fix)
I think this failure is connected to https://github.com/apache/arrow/issues/34789?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #35504: GH-35490: [Python] Interchange protocol: update tests for string and large_string
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #35504:
URL: https://github.com/apache/arrow/pull/35504#issuecomment-1541830672
@github-actions crossbow submit test-conda-python-*-pandas-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #35504: GH-35490: [Python] Interchange protocol: update tests for string and large_string
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #35504:
URL: https://github.com/apache/arrow/pull/35504#issuecomment-1543505425
Nightly failure is unrelated (but something else we should fix)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #35504: GH-35490: [Python] Interchange protocol: update tests for string and large_string
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #35504:
URL: https://github.com/apache/arrow/pull/35504#issuecomment-1543614526
Yes, indeed, I am looking at that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #35504: GH-35490: [Python] Interchange protocol: update tests for string and large_string
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #35504:
URL: https://github.com/apache/arrow/pull/35504#discussion_r1189429317
##########
python/pyarrow/tests/interchange/test_conversion.py:
##########
@@ -194,18 +194,19 @@ def test_roundtrip_pandas_string():
if Version(pd.__version__) < Version("1.6"):
pytest.skip(" Column.size() called as a method in pandas 2.0.0")
- # large string is not supported by pandas implementation
- table = pa.table({"a": pa.array(["a", "", "c"])})
+ arr = ["a", "", "c"]
Review Comment:
One more thing: we can maybe add a `None` here to also test missing values support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35504: GH-35490: [Python] Interchange protocol: update tests for string and large_string
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35504:
URL: https://github.com/apache/arrow/pull/35504#issuecomment-1544827214
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/7595771e3cde4f4987538896f80029ea...1403d9492f8b440dbee1d83d19b829eb/)
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/aff1acf29a764aa6b7168ca998eada20...5e2440a4022f4b69a299a0b1d4551575/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org