You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by tu...@apache.org on 2023/01/20 12:27:59 UTC

[arrow-rs] branch master updated: Show row_counts also for (FixedLen)ByteArray (#3573)

This is an automated email from the ASF dual-hosted git repository.

tustvold pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/master by this push:
     new a61da1e65 Show row_counts also for (FixedLen)ByteArray (#3573)
a61da1e65 is described below

commit a61da1e655e76e8676f1cdb021b13551e720b0de
Author: bmmeijers <b....@tudelft.nl>
AuthorDate: Fri Jan 20 13:27:52 2023 +0100

    Show row_counts also for (FixedLen)ByteArray (#3573)
---
 parquet/src/bin/parquet-index.rs | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/parquet/src/bin/parquet-index.rs b/parquet/src/bin/parquet-index.rs
index 6622783e6..b2f8b4d63 100644
--- a/parquet/src/bin/parquet-index.rs
+++ b/parquet/src/bin/parquet-index.rs
@@ -103,9 +103,11 @@ impl Args {
                 Index::INT96(v) => print_index(&v.indexes, offset_index, &row_counts)?,
                 Index::FLOAT(v) => print_index(&v.indexes, offset_index, &row_counts)?,
                 Index::DOUBLE(v) => print_index(&v.indexes, offset_index, &row_counts)?,
-                Index::BYTE_ARRAY(_) => println!("BYTE_ARRAY not supported"),
-                Index::FIXED_LEN_BYTE_ARRAY(_) => {
-                    println!("FIXED_LEN_BYTE_ARRAY not supported")
+                Index::BYTE_ARRAY(v) => {
+                    print_index(&v.indexes, offset_index, &row_counts)?
+                }
+                Index::FIXED_LEN_BYTE_ARRAY(v) => {
+                    print_index(&v.indexes, offset_index, &row_counts)?
                 }
             }
         }
@@ -130,7 +132,7 @@ fn compute_row_counts(offset_index: &[PageLocation], rows: i64) -> Vec<i64> {
 }
 
 /// Prints index information for a single column chunk
-fn print_index<T: std::fmt::Display>(
+fn print_index<T: std::fmt::Debug>(
     column_index: &[PageIndex<T>],
     offset_index: &[PageLocation],
     row_counts: &[i64],
@@ -154,12 +156,12 @@ fn print_index<T: std::fmt::Display>(
             idx, o.offset, o.compressed_page_size, row_count
         );
         match &c.min {
-            Some(m) => print!(", min {:>10}", m),
+            Some(m) => print!(", min {:>10?}", m),
             None => print!(", min {:>10}", "NONE"),
         }
 
         match &c.max {
-            Some(m) => print!(", max {:>10}", m),
+            Some(m) => print!(", max {:>10?}", m),
             None => print!(", max {:>10}", "NONE"),
         }
         println!()