You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2021/08/31 03:28:01 UTC

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3 

Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17820


Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................

IMPALA-10896: Fix impala shell tests on S3

The S3 tests were broken due to IMPALA-10778. The
strict_no_protocol option will not work on S3 because
the Hive mini cluster is not running there. This commit
adds a constraint to disable non HDFS tests for the
strict_no_protocol option.

Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
---
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
2 files changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/17820/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7456/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Sep 2021 19:03:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 5: Code-Review+2

This looks good to me


-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Sep 2021 14:50:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9433/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Sep 2021 19:16:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Sep 2021 21:05:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17820

to look at the new patch set (#2).

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................

IMPALA-10896: Fix impala shell tests on S3

The S3 tests were broken due to IMPALA-10778. The
strict_no_protocol option will not work on S3 because
the Hive mini cluster is not running there. This commit
adds a constraint to disable non HDFS tests for the
strict_no_protocol option.

Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
---
M tests/common/test_dimensions.py
M tests/shell/test_shell_commandline.py
2 files changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/17820/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9407/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Aug 2021 03:48:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Sep 2021 01:13:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17820/1/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:

http://gerrit.cloudera.org:8080/#/c/17820/1/tests/shell/test_shell_commandline.py@141
PS1, Line 141:     cls.ImpalaTestMatrix.add_dimension(create_client_protocol_strict_dimension())
Another option is to add a condition about whether you call this or create_client_protocol_no_strict_dimension(). i.e.
if IS_HDFS:
  ...add_dimension(create_client_protocol_strict_dimension())
else:
  ...add_dimension(create_client_protocol_no_strict_dimension())

This could also be put inside create_client_protocol_strict_dimension() itself (i.e. it looks at IS_HDFS and returns the right thing).



-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Sep 2021 18:39:52 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9432/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Sep 2021 19:16:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7459/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Sep 2021 14:51:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 4:

(1 comment)

This makes sense to me. We can confirm that tests pass with this change, then I will approve.

http://gerrit.cloudera.org:8080/#/c/17820/4/tests/common/test_dimensions.py
File tests/common/test_dimensions.py:

http://gerrit.cloudera.org:8080/#/c/17820/4/tests/common/test_dimensions.py@135
PS4, Line 135: fiel
Nit: file



-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Sep 2021 19:12:31 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Sep 2021 14:51:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17820

to look at the new patch set (#3).

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................

IMPALA-10896: Fix impala shell tests on S3

The S3 tests were broken due to IMPALA-10778. The
strict_no_protocol option will not work on S3 because
the Hive mini cluster is not running there. This commit
adds a constraint to disable non HDFS tests for the
strict_no_protocol option.

Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
---
M tests/common/test_dimensions.py
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/17820/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9431/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Sep 2021 19:13:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17820

to look at the new patch set (#4).

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................

IMPALA-10896: Fix impala shell tests on S3

The S3 tests were broken due to IMPALA-10778. The
strict_no_protocol option will not work on S3 because
the Hive mini cluster is not running there. This commit
adds a constraint to disable non HDFS tests for the
strict_no_protocol option.

Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
---
M tests/common/test_dimensions.py
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/17820/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17820/2/tests/common/test_dimensions.py
File tests/common/test_dimensions.py:

http://gerrit.cloudera.org:8080/#/c/17820/2/tests/common/test_dimensions.py@140
PS2, Line 140: :
flake8: E999 SyntaxError: invalid syntax



-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Sep 2021 18:52:19 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17820/1/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/17820/1/tests/shell/test_shell_interactive.py@174
PS1, Line 174: I
flake8: F821 undefined name 'IS_HDFS'



-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Aug 2021 03:29:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................

IMPALA-10896: Fix impala shell tests on S3

The S3 tests were broken due to IMPALA-10778. The
strict_no_protocol option will not work on S3 because
the Hive mini cluster is not running there. This commit
adds a constraint to disable non HDFS tests for the
strict_no_protocol option.

Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Reviewed-on: http://gerrit.cloudera.org:8080/17820
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/test_dimensions.py
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17820/3/tests/common/test_dimensions.py
File tests/common/test_dimensions.py:

http://gerrit.cloudera.org:8080/#/c/17820/3/tests/common/test_dimensions.py@140
PS3, Line 140: :
flake8: E999 SyntaxError: invalid syntax



-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Sep 2021 18:54:46 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9434/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Sep 2021 19:42:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10896: Fix impala shell tests on S3

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17820

to look at the new patch set (#5).

Change subject: IMPALA-10896: Fix impala shell tests on S3
......................................................................

IMPALA-10896: Fix impala shell tests on S3

The S3 tests were broken due to IMPALA-10778. The
strict_no_protocol option will not work on S3 because
the Hive mini cluster is not running there. This commit
adds a constraint to disable non HDFS tests for the
strict_no_protocol option.

Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
---
M tests/common/test_dimensions.py
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/17820/5
-- 
To view, visit http://gerrit.cloudera.org:8080/17820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4
Gerrit-Change-Number: 17820
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>