You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by bt...@apache.org on 2022/04/18 06:50:39 UTC
[james-project] 02/11: [PERF] CassandraMailboxDAO: parse UDT once
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 1c6f3c0048cc29ad96386cb3558d1c35dcc2fc3d
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Mon Apr 11 15:16:00 2022 +0700
[PERF] CassandraMailboxDAO: parse UDT once
User Defined Type parsing is expensive - for IMAP workload 0.33%
CPU and 0.65% of memory allocation -
and was done needlessly twice. We should do it only once.
---
.../mailbox/cassandra/mail/CassandraMailboxDAO.java | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMailboxDAO.java b/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMailboxDAO.java
index f799f2621b..de2a059f7c 100644
--- a/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMailboxDAO.java
+++ b/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMailboxDAO.java
@@ -50,6 +50,7 @@ import com.datastax.driver.core.ConsistencyLevel;
import com.datastax.driver.core.PreparedStatement;
import com.datastax.driver.core.Row;
import com.datastax.driver.core.Session;
+import com.datastax.driver.core.UDTValue;
import com.datastax.driver.core.querybuilder.QueryBuilder;
import reactor.core.publisher.Flux;
@@ -146,13 +147,16 @@ public class CassandraMailboxDAO {
private Mono<Mailbox> mailboxFromRow(Row row, CassandraId cassandraId) {
return sanitizeUidValidity(cassandraId, row.getLong(UIDVALIDITY))
- .map(uidValidity -> new Mailbox(
- new MailboxPath(
- row.getUDTValue(MAILBOX_BASE).getString(CassandraMailboxTable.MailboxBase.NAMESPACE),
- Username.of(row.getUDTValue(MAILBOX_BASE).getString(CassandraMailboxTable.MailboxBase.USER)),
- row.getString(NAME)),
- uidValidity,
- cassandraId));
+ .map(uidValidity -> {
+ UDTValue mailboxBase = row.getUDTValue(MAILBOX_BASE);
+ return new Mailbox(
+ new MailboxPath(
+ mailboxBase.getString(CassandraMailboxTable.MailboxBase.NAMESPACE),
+ Username.of(mailboxBase.getString(CassandraMailboxTable.MailboxBase.USER)),
+ row.getString(NAME)),
+ uidValidity,
+ cassandraId);
+ });
}
private Mono<UidValidity> sanitizeUidValidity(CassandraId cassandraId, long uidValidityAsLong) {
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org