You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/01 20:31:50 UTC

[GitHub] [geode] kirklund commented on a change in pull request #6916: GEODE-9635: wait for bucket initialization, after clean queue

kirklund commented on a change in pull request #6916:
URL: https://github.com/apache/geode/pull/6916#discussion_r720523813



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
##########
@@ -566,10 +566,8 @@ public void addShadowPartitionedRegionForUserPR(PartitionedRegion userPR,
         // Add the overflow statistics to the mbean
         addOverflowStatisticsToMBean(cache, prQ);
 
-        if (!cleanQueues) {
-          // Wait for buckets to be recovered.
-          prQ.shadowPRWaitForBucketRecovery();
-        }
+        // Wait for buckets to be recovered.
+        prQ.shadowPRWaitForBucketRecovery();

Review comment:
       Please add test(s) to ParallelGatewaySenderQueueJUnitTest (the unit test) for this change in addition to any integration tests or distributed tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org