You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/29 10:14:55 UTC
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request
#4994: bugfix for update statement
tristaZero opened a new pull request #4994: bugfix for update statement
URL: https://github.com/apache/incubator-shardingsphere/pull/4994
Fixes #4993.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4994:
bugfix for update statement
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4994: bugfix for update statement
URL: https://github.com/apache/incubator-shardingsphere/pull/4994#issuecomment-605616328
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994?src=pr&el=h1) Report
> Merging [#4994](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/fec78b9b80028d75f1f892d0d7d3c85e752982ff&el=desc) will **decrease** coverage by `0.17%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4994 +/- ##
============================================
- Coverage 54.02% 53.85% -0.18%
Complexity 442 442
============================================
Files 1146 1145 -1
Lines 20465 20469 +4
Branches 3744 3745 +1
============================================
- Hits 11057 11023 -34
- Misses 8704 8744 +40
+ Partials 704 702 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...gsphere/sql/parser/mysql/visitor/MySQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL015U1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...phere/sql/parser/oracle/visitor/OracleVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3IvT3JhY2xlVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...l/parser/postgresql/visitor/PostgreSQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9Qb3N0Z3JlU1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gsphere/sql/parser/sql92/visitor/SQL92Visitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL1NRTDkyVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...sql/parser/sqlserver/visitor/SQLServerVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWxzZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3Fsc2VydmVyL3Zpc2l0b3IvU1FMU2VydmVyVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...sql/parser/binder/segment/table/TablesContext.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvc2VnbWVudC90YWJsZS9UYWJsZXNDb250ZXh0LmphdmE=) | `62.96% <0.00%> (-14.31%)` | `0.00% <0.00%> (ø%)` | |
| [...ingjdbc/jdbc/core/statement/ShardingStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3RhdGVtZW50LmphdmE=) | `61.29% <0.00%> (-3.23%)` | `0.00% <0.00%> (ø%)` | |
| [...dingjdbc/jdbc/core/resultset/EncryptResultSet.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvcmVzdWx0c2V0L0VuY3J5cHRSZXN1bHRTZXQuamF2YQ==) | `27.20% <0.00%> (-1.15%)` | `0.00% <0.00%> (ø%)` | |
| [...apache/shardingsphere/shardingproxy/Bootstrap.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3Byb3h5L0Jvb3RzdHJhcC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...re/encrypt/merge/EncryptResultDecoratorEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1tZXJnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9tZXJnZS9FbmNyeXB0UmVzdWx0RGVjb3JhdG9yRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [19 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994?src=pr&el=footer). Last update [fec78b9...9858249](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4994:
bugfix for update statement
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4994: bugfix for update statement
URL: https://github.com/apache/incubator-shardingsphere/pull/4994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4994:
bugfix for update statement
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4994: bugfix for update statement
URL: https://github.com/apache/incubator-shardingsphere/pull/4994#issuecomment-605616722
## Pull Request Test Coverage Report for [Build 10687](https://coveralls.io/builds/29688048)
* **0** of **19** **(0.0%)** changed or added relevant lines in **5** files are covered.
* **5** unchanged lines in **5** files lost coverage.
* Overall coverage decreased (**-0.05%**) to **57.34%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/OracleVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Foracle%2Fvisitor%2FOracleVisitor.java#L359) | 0 | 3 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2FPostgreSQLVisitor.java#L361) | 0 | 3 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/SQLServerVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsqlserver%2Fvisitor%2FSQLServerVisitor.java#L360) | 0 | 3 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/MySQLVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fmysql%2Fvisitor%2FMySQLVisitor.java#L378) | 0 | 5 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/sql92/visitor/SQL92Visitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql92%2Fvisitor%2FSQL92Visitor.java#L351) | 0 | 5 | 0.0%
<!-- | **Total:** | **0** | **19** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/MySQLVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fmysql%2Fvisitor%2FMySQLVisitor.java#L379) | 1 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/OracleVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Foracle%2Fvisitor%2FOracleVisitor.java#L360) | 1 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2FPostgreSQLVisitor.java#L362) | 1 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/sql92/visitor/SQL92Visitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql92%2Fvisitor%2FSQL92Visitor.java#L352) | 1 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/SQLServerVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsqlserver%2Fvisitor%2FSQLServerVisitor.java#L361) | 1 | 0% |
<!-- | **Total:** | **5** | | -->
| Totals | [](https://coveralls.io/builds/29688048) |
| :-- | --: |
| Change from base [Build 10686](https://coveralls.io/builds/29687934): | -0.05% |
| Covered Lines: | 11737 |
| Relevant Lines: | 20469 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4994:
bugfix for update statement
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4994: bugfix for update statement
URL: https://github.com/apache/incubator-shardingsphere/pull/4994#issuecomment-605617065
This PR needs any committer merging, thx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services