You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Patrick Kling (JIRA)" <ji...@apache.org> on 2010/11/24 20:35:14 UTC
[jira] Created: (HADOOP-7049) TestReconfiguration should be junit
v4
TestReconfiguration should be junit v4
--------------------------------------
Key: HADOOP-7049
URL: https://issues.apache.org/jira/browse/HADOOP-7049
Project: Hadoop Common
Issue Type: Bug
Components: conf
Affects Versions: 0.23.0
Reporter: Patrick Kling
Assignee: Patrick Kling
Priority: Trivial
TestReconfiguration should be a junit v4 unit test. I'll also add some messages to the assertions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7049) TestReconfiguration should be junit
v4
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7049:
--------------------------------
Fix Version/s: 0.23.0
Issue Type: Improvement (was: Bug)
Hadoop Flags: [Reviewed]
I've committed this. Thanks Patrick!
> TestReconfiguration should be junit v4
> --------------------------------------
>
> Key: HADOOP-7049
> URL: https://issues.apache.org/jira/browse/HADOOP-7049
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Priority: Trivial
> Fix For: 0.23.0
>
> Attachments: HADOOP-7049.2.patch, HADOOP-7049.patch
>
>
> TestReconfiguration should be a junit v4 unit test. I'll also add some messages to the assertions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7049) TestReconfiguration should be junit
v4
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935618#action_12935618 ]
Konstantin Boudnik commented on HADOOP-7049:
--------------------------------------------
looking good. I would suggest to replace {{import static org.junit.Assert.*;}} with only needed imports. Looks like you're using only two of them {{assertTrue}} and {{assertFalse}}
> TestReconfiguration should be junit v4
> --------------------------------------
>
> Key: HADOOP-7049
> URL: https://issues.apache.org/jira/browse/HADOOP-7049
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Priority: Trivial
> Attachments: HADOOP-7049.2.patch, HADOOP-7049.patch
>
>
> TestReconfiguration should be a junit v4 unit test. I'll also add some messages to the assertions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7049) TestReconfiguration should be junit
v4
Posted by "Patrick Kling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Kling updated HADOOP-7049:
----------------------------------
Attachment: HADOOP-7049.patch
> TestReconfiguration should be junit v4
> --------------------------------------
>
> Key: HADOOP-7049
> URL: https://issues.apache.org/jira/browse/HADOOP-7049
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Priority: Trivial
> Attachments: HADOOP-7049.patch
>
>
> TestReconfiguration should be a junit v4 unit test. I'll also add some messages to the assertions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7049) TestReconfiguration should be junit
v4
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964611#action_12964611 ]
Konstantin Boudnik commented on HADOOP-7049:
--------------------------------------------
bq. Perhaps file a separate jira if you think we should switch them all over to be explicit.
I don't suggest to change them all over the place but I don't see why we need to add insult to injury and keep doing this for the test code while it isn't welcome for the rest of the code. Besides [a similar question|https://issues.apache.org/jira/browse/HADOOP-7014?focusedCommentId=12931310&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12931310] has been raised before
> TestReconfiguration should be junit v4
> --------------------------------------
>
> Key: HADOOP-7049
> URL: https://issues.apache.org/jira/browse/HADOOP-7049
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Priority: Trivial
> Fix For: 0.23.0
>
> Attachments: HADOOP-7049.2.patch, HADOOP-7049.patch
>
>
> TestReconfiguration should be a junit v4 unit test. I'll also add some messages to the assertions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7049) TestReconfiguration should be junit
v4
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964700#action_12964700 ]
Hudson commented on HADOOP-7049:
--------------------------------
Integrated in Hadoop-Common-trunk #529 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/529/])
HADOOP-7049. TestReconfiguration should be junit v4. Contributed by Patrick Kling
> TestReconfiguration should be junit v4
> --------------------------------------
>
> Key: HADOOP-7049
> URL: https://issues.apache.org/jira/browse/HADOOP-7049
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Priority: Trivial
> Fix For: 0.23.0
>
> Attachments: HADOOP-7049.2.patch, HADOOP-7049.patch
>
>
> TestReconfiguration should be a junit v4 unit test. I'll also add some messages to the assertions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7049) TestReconfiguration should be junit
v4
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964598#action_12964598 ]
Eli Collins commented on HADOOP-7049:
-------------------------------------
+1
I think the wildcard in the Assert import is OK, we use it in a lot of the tests. Perhaps file a separate jira if you think we should switch them all over to be explicit.
> TestReconfiguration should be junit v4
> --------------------------------------
>
> Key: HADOOP-7049
> URL: https://issues.apache.org/jira/browse/HADOOP-7049
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Priority: Trivial
> Attachments: HADOOP-7049.2.patch, HADOOP-7049.patch
>
>
> TestReconfiguration should be a junit v4 unit test. I'll also add some messages to the assertions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7049) TestReconfiguration should be junit
v4
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7049:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> TestReconfiguration should be junit v4
> --------------------------------------
>
> Key: HADOOP-7049
> URL: https://issues.apache.org/jira/browse/HADOOP-7049
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Priority: Trivial
> Fix For: 0.23.0
>
> Attachments: HADOOP-7049.2.patch, HADOOP-7049.patch
>
>
> TestReconfiguration should be a junit v4 unit test. I'll also add some messages to the assertions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7049) TestReconfiguration should be junit
v4
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935467#action_12935467 ]
Hadoop QA commented on HADOOP-7049:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12460392/HADOOP-7049.2.patch
against trunk revision 1038493.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/120//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/120//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/120//console
This message is automatically generated.
> TestReconfiguration should be junit v4
> --------------------------------------
>
> Key: HADOOP-7049
> URL: https://issues.apache.org/jira/browse/HADOOP-7049
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Priority: Trivial
> Attachments: HADOOP-7049.2.patch, HADOOP-7049.patch
>
>
> TestReconfiguration should be a junit v4 unit test. I'll also add some messages to the assertions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7049) TestReconfiguration should be junit
v4
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964622#action_12964622 ]
Hudson commented on HADOOP-7049:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #447 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/447/])
HADOOP-7049. TestReconfiguration should be junit v4. Contributed by Patrick Kling
> TestReconfiguration should be junit v4
> --------------------------------------
>
> Key: HADOOP-7049
> URL: https://issues.apache.org/jira/browse/HADOOP-7049
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Priority: Trivial
> Fix For: 0.23.0
>
> Attachments: HADOOP-7049.2.patch, HADOOP-7049.patch
>
>
> TestReconfiguration should be a junit v4 unit test. I'll also add some messages to the assertions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7049) TestReconfiguration should be junit
v4
Posted by "Patrick Kling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Kling updated HADOOP-7049:
----------------------------------
Status: Patch Available (was: Open)
> TestReconfiguration should be junit v4
> --------------------------------------
>
> Key: HADOOP-7049
> URL: https://issues.apache.org/jira/browse/HADOOP-7049
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Priority: Trivial
> Attachments: HADOOP-7049.2.patch, HADOOP-7049.patch
>
>
> TestReconfiguration should be a junit v4 unit test. I'll also add some messages to the assertions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7049) TestReconfiguration should be junit
v4
Posted by "Patrick Kling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Kling updated HADOOP-7049:
----------------------------------
Attachment: HADOOP-7049.2.patch
Fixed typo.
> TestReconfiguration should be junit v4
> --------------------------------------
>
> Key: HADOOP-7049
> URL: https://issues.apache.org/jira/browse/HADOOP-7049
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.0
> Reporter: Patrick Kling
> Assignee: Patrick Kling
> Priority: Trivial
> Attachments: HADOOP-7049.2.patch, HADOOP-7049.patch
>
>
> TestReconfiguration should be a junit v4 unit test. I'll also add some messages to the assertions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.