You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nemo.apache.org by GitBox <gi...@apache.org> on 2018/08/10 06:06:32 UTC

[GitHub] wonook opened a new pull request #101: 168 fine grained execution property check

wonook opened a new pull request #101: 168 fine grained execution property check
URL: https://github.com/apache/incubator-nemo/pull/101
 
 
   JIRA: [NEMO-168: Fine-grained Execution Property Check](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-168)
   
   **Major changes:**
   - Implements setPropertyPermanently method, to be able to permanently set execution properties.
   - Implements finalization of execution properties in the execution property map.
   - Removed 'strict checking' mode from PolicyBuilder, as it is no longer necessary.
   
   **Minor changes to note:**
   - Fixes overused RuntimeExceptions into appropriate exceptions.
   - Type specifications where it was neglected.
   - Replaced calling getExecutionProperty then manually doing something into getPropertyValue and setProperty methods.
   
   **Tests for the changes:**
   - I've added a buildEmptyDAG method to be able to create a mock DAG that can be used throughout the tests.
   - I've also added unit tests to test the methods newly implemented in the execution property map.
   - I've added appropriate unit tests that expect particular outputs from various policies.
   
   **Other comments:**
   - N/A
   
   resolves [NEMO-168](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-168)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services