You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2023/05/25 07:05:35 UTC

[GitHub] [inlong] fuweng11 opened a new pull request, #8089: [INLONG-8088][Manager] Support configure heartbeat timeout interval

fuweng11 opened a new pull request, #8089:
URL: https://github.com/apache/inlong/pull/8089

   ### Prepare a Pull Request
   - Fixes #8088 
   
   ### Motivation
   
   Support configure heartbeat timeout interval.
   
   ### Modifications
   
   Support configure heartbeat timeout interval.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang merged pull request #8089: [INLONG-8088][Manager] Support configure heartbeat timeout interval

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #8089:
URL: https://github.com/apache/inlong/pull/8089


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] vernedeng commented on a diff in pull request #8089: [INLONG-8088][Manager] Support configure heartbeat timeout interval

Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng commented on code in PR #8089:
URL: https://github.com/apache/inlong/pull/8089#discussion_r1206158061


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/heartbeat/HeartbeatManager.java:
##########
@@ -106,7 +110,7 @@ public void init() {
         // When the manager restarts, set the heartbeat timeout state of all nodes
         // and wait for the heartbeat report of the corresponding node
         clusterNodeMapper.updateStatus(null, NodeStatus.HEARTBEAT_TIMEOUT.getStatus(), NodeStatus.NORMAL.getStatus());
-        long expireTime = heartbeatInterval() * 2L;
+        long expireTime = heartbeatInterval() * heartbeatInterval;

Review Comment:
   heartbeatInterval  -> heartbeatIntervalFactor



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] fuweng11 commented on a diff in pull request #8089: [INLONG-8088][Manager] Support configure heartbeat timeout interval

Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #8089:
URL: https://github.com/apache/inlong/pull/8089#discussion_r1205483068


##########
inlong-manager/manager-web/src/main/resources/application-dev.properties:
##########
@@ -86,6 +86,9 @@ data.cleansing.batchSize=100
 # Whether to use ZooKeeper to manage the Sort task config, default is false, which means not using ZooKeeper
 sort.enable.zookeeper=false
 
+# cluster node timeout interval of heartbeat unit: 5s
+cluster.heartbeat.interval=30
+
 # If turned on, synchronizing change the source status when the agent heartbeat times out

Review Comment:
   The interval multiplied by 5s indicates the true timeout interval, because 5s is the interval shared by the agent and dataproxy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #8089: [INLONG-8088][Manager] Support configure heartbeat timeout interval

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #8089:
URL: https://github.com/apache/inlong/pull/8089#discussion_r1205474316


##########
inlong-manager/manager-web/src/main/resources/application-dev.properties:
##########
@@ -86,6 +86,9 @@ data.cleansing.batchSize=100
 # Whether to use ZooKeeper to manage the Sort task config, default is false, which means not using ZooKeeper
 sort.enable.zookeeper=false
 
+# cluster node timeout interval of heartbeat unit: 5s
+cluster.heartbeat.interval=30
+
 # If turned on, synchronizing change the source status when the agent heartbeat times out

Review Comment:
   ```suggestion
   # cluster node timeout interval of heartbeat, unit: second
   cluster.heartbeat.interval=30
   
   # If turned on, synchronizing change the source status when the agent heartbeat timeout
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org