You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/09/20 22:53:27 UTC
Review Request 68789: ATLAS-2883: updated StructInstance.setNull() to
handle all datatypes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68789/
-----------------------------------------------------------
Review request for atlas, Abhishek Kadam, Apoorv Naik, Ashutosh Mestry, keval bhatt, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-2883
https://issues.apache.org/jira/browse/ATLAS-2883
Repository: atlas
Description
-------
StructInstance.setNull() did not handle datatypes long/short/float/double/byte. Fixed the method to handle these types as well
Diffs
-----
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 3136ae27c
Diff: https://reviews.apache.org/r/68789/diff/1/
Testing
-------
Pre-commit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/677/
Thanks,
Madhan Neethiraj
Re: Review Request 68789: ATLAS-2883: updated
StructInstance.setNull() to handle all datatypes
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68789/#review208823
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Sept. 20, 2018, 3:53 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68789/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2018, 3:53 p.m.)
>
>
> Review request for atlas, Abhishek Kadam, Apoorv Naik, Ashutosh Mestry, keval bhatt, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2883
> https://issues.apache.org/jira/browse/ATLAS-2883
>
>
> Repository: atlas
>
>
> Description
> -------
>
> StructInstance.setNull() did not handle datatypes long/short/float/double/byte. Fixed the method to handle these types as well
>
>
> Diffs
> -----
>
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 3136ae27c
>
>
> Diff: https://reviews.apache.org/r/68789/diff/1/
>
>
> Testing
> -------
>
> Pre-commit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/677/
>
>
> Thanks,
>
> Madhan Neethiraj
>
>