[jira] [Commented] (SOLR-2571) IndexBasedSpellChecker "thresholdTokenFrequency" fails with a ClassCastException on startup

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042683#comment-13042683 ] 

Robert Muir commented on SOLR-2571:
-----------------------------------

Hi James, I'm confused about this one a little bit. Perhaps DirectSolrSpellChecker is actually wrong?

If I configure the thing like this:

{noformat}
<float name="thresholdTokenFrequency">0.07</float>
{noformat}

Then it does apply the parameter. I guess what I'm asking is, if in general we should be using int/float/etc in these types and not <str> (especially DirectSolrSpellChecker which takes a lot of numeric parameters but expects them all to be <str>). Just glancing through solrconfig.xml its not clear that there is a precedent, it appears inconsistent as far as numeric parameters.


> IndexBasedSpellChecker "thresholdTokenFrequency" fails with a ClassCastException on startup
> -------------------------------------------------------------------------------------------
>
>                 Key: SOLR-2571
>                 URL: https://issues.apache.org/jira/browse/SOLR-2571
>             Project: Solr
>          Issue Type: Bug
>          Components: spellchecker
>    Affects Versions: 1.4.1, 3.1, 4.0
>            Reporter: James Dyer
>            Priority: Minor
>             Fix For: 3.3, 4.0
>
>         Attachments: SOLR-2571.patch, SOLR-2571.solr3.2.patch
>
>
> When parsing the configuration for thresholdTokenFrequency", the IndexBasedSpellChecker tries to pull a Float from the DataConfig.xml-derrived NamedList.  However, this comes through as a String.  Therefore, a ClassCastException is always thrown whenever this parameter is specified.  The code ought to be doing "Float.parseFloat(...)" on the value.
> This looks like a nice feature to use in cases the data contains misspelled or rare words leading to spurious "correct" queries.  I would have liked to have used this with a project we just completed however this bug prevented that.  This issue came up recently in the User's mailing list so I am raising an issue now.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org