[GitHub] flink issue #3394: [FLINK-5810] [flip6] Introduce a hardened slot manager

[tillrohrmann <gi...@git.apache.org>]

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/3394
  
    Thanks for the thorough review @StephanEwen. I'll will pull in your commit with the improvements.
    
    Concerning the other points you've raised:
    
    - I think you're right. The timeouts should be configurable. I would like to do as a follow up because the PR is already big enough.
    
    - You're also right that the timeout logic is not properly working. I agree that the (2) approach is probably less brittle. Additionally we would get rid of the timeout identifier generation.
    
    - I think it is fair to assume that the number of slots don't change over the lifetime of a `TaskManager`. I will change the implementation accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---