[GitHub] [ozone] elek commented on a change in pull request #2183: HDDS-5099. Error with unit test for hdds.container-service TestSchemaOneBackwardsCompatibility

[GitBox <gi...@apache.org>]

elek commented on a change in pull request #2183:
URL: https://github.com/apache/ozone/pull/2183#discussion_r625665399



##########
File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestSchemaOneBackwardsCompatibility.java
##########
@@ -279,6 +288,8 @@ public void testDelete() throws Exception {
               refCountedDB.getStore().getMetadataTable();
       assertEquals(expectedRegularBlocks + expectedDeletingBlocks,
               (long)metadataTable.get(OzoneConsts.BLOCK_COUNT));
+    //} catch(IOException ex) {

Review comment:
       Do we need this commented out test? Or can we just remove this part?

##########
File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/testutils/BlockDeletingServiceTestImpl.java
##########
@@ -80,6 +80,7 @@ public void start() {
           break;
         }
         Future<?> future = this.getExecutorService().submit(svc);
+

Review comment:
       This line may not be required to modified and this case this test will remain unchanged.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org