[GitHub] merlimat commented on a change in pull request #627: Reduce thread executor pool sizes when running unit tests

[gi...@git.apache.org]

merlimat commented on a change in pull request #627: Reduce thread executor pool sizes when running unit tests
URL: https://github.com/apache/incubator-pulsar/pull/627#discussion_r130998656
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
 ##########
 @@ -78,6 +78,16 @@
  * Main class for Pulsar broker service
  */
 public class PulsarService implements AutoCloseable {
+
+    private static final int EXECUTOR_THREAD_COUNT = Integer
+            .parseInt(System.getProperty("pulsar.executor-thread-count", "20"));
 
 Review comment:
   I agree on that but I was having 2 concerns about it: 
    * We might end up many executor sizes in the `ServiceConfiguration` and it would be tricky to properly explain all of them
    * We typically provide a default value in the `conf/broker.conf`. If the default is dependent on the number of cores, that might be tricky.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services