You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "obabichevjb (via GitHub)" <gi...@apache.org> on 2026/08/27 11:10:15 UTC
[PR] chore: add JSpecify @NullMarked annotations to org.apache.rocketmq.client.apis [rocketmq-clients]
obabichevjb opened a new pull request, #1351:
URL: https://github.com/apache/rocketmq-clients/pull/1351
### Which Issue(s) This PR Fixes
Fixes #1350
### Brief Description
This PR adds JSpecify `@NullMarked` annotations to all 32 public types in the `client-apis` module, enabling Kotlin consumers to receive full nullability information instead of unsafe platform types (`String!`, `Map<String?,?>!`, etc.).
### How Did You Test This Change?
- **Maven build**: `mvn clean install` — all tests pass, zero behavioral changes
- **Kotlin interop**: verified with Kotlin 2.4.10 — compiler produces `"Unnecessary safe call on a non-null receiver"` warnings on annotated getters, confirming annotations are recognized at the Java-Kotlin boundary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add JSpecify @NullMarked annotations to org.apache.rocketmq.client.apis [rocketmq-clients]
Posted by "obabichevjb (via GitHub) via commits" <co...@rocketmq.apache.org>.
obabichevjb commented on PR #1351:
URL: https://github.com/apache/rocketmq-clients/pull/1351#issuecomment-6576914689
https://github.com/apache/rocketmq-clients/pull/1351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add JSpecify @NullMarked annotations to org.apache.rocketmq.client.apis [rocketmq-clients]
Posted by "obabichevjb (via GitHub) via commits" <co...@rocketmq.apache.org>.
obabichevjb commented on PR #1351:
URL: https://github.com/apache/rocketmq-clients/pull/1351#issuecomment-6576921028
Is there any chance we could move forward with this PR? If anything is blocking it, I’d be happy to help get it over the finish line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add JSpecify @NullMarked annotations to org.apache.rocketmq.client.apis [rocketmq-clients]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1351:
URL: https://github.com/apache/rocketmq-clients/pull/1351#issuecomment-6006781103
This PR is stale because it has been open for 30 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add JSpecify @NullMarked annotations to org.apache.rocketmq.client.apis [rocketmq-clients]
Posted by "obabichevjb (via GitHub)" <gi...@apache.org>.
obabichevjb commented on PR #1351:
URL: https://github.com/apache/rocketmq-clients/pull/1351#issuecomment-6015446930
-- Do not mark it as stale
We will be still happy to bring nullability markers to RocketMQ for better Kotlin support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org