You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/04 07:41:03 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #10242: build: upgrade typescript, eslint and prettier
ktmud opened a new pull request #10242:
URL: https://github.com/apache/incubator-superset/pull/10242
### SUMMARY
Upgrade Typescript, ESLint, Prettier and all their related packages.
Many (thousands) new lint errors/warnings popping up, regrettably making #10067 worse.
Will take following approach to clean them up:
1. Try `eslint --fix` and `prettier --write`
1. Disable too frequent errors or change them to warning
2. Fix the easier/safer ones
3. Make sure no code logic changes
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TEST PLAN
Rely on CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10242: build: upgrade typescript, eslint and prettier
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10242:
URL: https://github.com/apache/incubator-superset/pull/10242#issuecomment-691297657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud closed pull request #10242: build: upgrade typescript, eslint and prettier
Posted by GitBox <gi...@apache.org>.
ktmud closed pull request #10242:
URL: https://github.com/apache/incubator-superset/pull/10242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10242: build: upgrade typescript, eslint and prettier
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10242:
URL: https://github.com/apache/incubator-superset/pull/10242#discussion_r449749671
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -16,6 +16,70 @@
* specific language governing permissions and limitations
* under the License.
*/
+const rules = {
Review comment:
This extraction is temporary. Will move it back to make PR easier to review and do the extraction in another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud closed pull request #10242: build: upgrade typescript, eslint and prettier
Posted by GitBox <gi...@apache.org>.
ktmud closed pull request #10242:
URL: https://github.com/apache/incubator-superset/pull/10242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10242: build: upgrade typescript, eslint and prettier
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10242:
URL: https://github.com/apache/incubator-superset/pull/10242#issuecomment-691297657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on pull request #10242: build: upgrade typescript, eslint and prettier
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10242:
URL: https://github.com/apache/incubator-superset/pull/10242#issuecomment-687720367
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10242: build: upgrade typescript, eslint and prettier
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10242:
URL: https://github.com/apache/incubator-superset/pull/10242#issuecomment-691297657
Superseded by #10839
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud closed pull request #10242: build: upgrade typescript, eslint and prettier
Posted by GitBox <gi...@apache.org>.
ktmud closed pull request #10242:
URL: https://github.com/apache/incubator-superset/pull/10242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud closed pull request #10242: build: upgrade typescript, eslint and prettier
Posted by GitBox <gi...@apache.org>.
ktmud closed pull request #10242:
URL: https://github.com/apache/incubator-superset/pull/10242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org