You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "David Driscoll (JIRA)" <ji...@apache.org> on 2009/04/02 17:51:13 UTC
[jira] Created: (SHINDIG-1006) AuthType was not always being
saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce
not generated
AuthType was not always being saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce not generated
---------------------------------------------------------------------------------------------------------------------
Key: SHINDIG-1006
URL: https://issues.apache.org/jira/browse/SHINDIG-1006
Project: Shindig
Issue Type: Bug
Components: Java
Affects Versions: trunk
Reporter: David Driscoll
Fix For: trunk
AuthType was not always being saved/maintained thru the entire workflow, would get overridden to "NONE" at times.
IgnoreCache flag not always used. Added .setIgnoreCache call to HttpPreloader.java to obey IgnoreCache flag
OAuth parameter Nonce not generated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1006) AuthType was not always being
saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce
not generated
Posted by "David Driscoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737755#action_12737755 ]
David Driscoll commented on SHINDIG-1006:
-----------------------------------------
I will create an additional test case to repro the nonce issue.
> AuthType was not always being saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce not generated
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1006
> URL: https://issues.apache.org/jira/browse/SHINDIG-1006
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 1.1-BETA1
> Reporter: David Driscoll
> Fix For: 1.1-BETA2
>
> Attachments: HttpPreloader_patch.txt, HtttpPreloader_patchB.txt, MakeRequestClient_patch.txt, OAuthRequest_patch.txt, OAuthRequestTest_patch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> AuthType was not always being saved/maintained thru the entire workflow, would get overridden to "NONE" at times.
> IgnoreCache flag not always used. Added .setIgnoreCache call to HttpPreloader.java to obey IgnoreCache flag
> OAuth parameter Nonce not generated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1006) AuthType was not always being
saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce
not generated
Posted by "David Driscoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Driscoll updated SHINDIG-1006:
------------------------------------
Attachment: OAuthRequestTest_patch.txt
These are new tests for these patches.
Note: MakeRequestClient.java is used by these tests, and was updated as well.
2. Updated package: test/src/java - org.apache.shindig.gadgets.oauth, Class: OAuthRequestTest.java
a) Added : MakeNonSocialClientWithAuthType
b) Added Test: testOAuthFlow_setAuthType()
c) Added Test: testOAuthFlow_setIgnoreCache()
> AuthType was not always being saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce not generated
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1006
> URL: https://issues.apache.org/jira/browse/SHINDIG-1006
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: trunk
> Reporter: David Driscoll
> Fix For: trunk
>
> Attachments: HttpPreloader_patch.txt, MakeRequestClient_patch.txt, OAuthRequest_patch.txt, OAuthRequestTest_patch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> AuthType was not always being saved/maintained thru the entire workflow, would get overridden to "NONE" at times.
> IgnoreCache flag not always used. Added .setIgnoreCache call to HttpPreloader.java to obey IgnoreCache flag
> OAuth parameter Nonce not generated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1006) AuthType was not always being
saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce
not generated
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707452#action_12707452 ]
Brian Eaton commented on SHINDIG-1006:
--------------------------------------
Re: nonce. It is being generated by the current code, the OAuth libraries automatically add this if it's missing. Not sure why you think it isn't present, if you have a reproducible test case let me know.
Re: preload ignore cache. OK, I'll, add this.
Re: propagating auth type to down stream fetchers: why?
> AuthType was not always being saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce not generated
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1006
> URL: https://issues.apache.org/jira/browse/SHINDIG-1006
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: trunk
> Reporter: David Driscoll
> Fix For: trunk
>
> Attachments: HttpPreloader_patch.txt, HtttpPreloader_patchB.txt, MakeRequestClient_patch.txt, OAuthRequest_patch.txt, OAuthRequestTest_patch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> AuthType was not always being saved/maintained thru the entire workflow, would get overridden to "NONE" at times.
> IgnoreCache flag not always used. Added .setIgnoreCache call to HttpPreloader.java to obey IgnoreCache flag
> OAuth parameter Nonce not generated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1006) AuthType was not always being
saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce
not generated
Posted by "David Driscoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Driscoll updated SHINDIG-1006:
------------------------------------
Attachment: MakeRequestClient_patch.txt
HttpPreloader_patch.txt
OAuthRequest_patch.txt
> AuthType was not always being saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce not generated
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1006
> URL: https://issues.apache.org/jira/browse/SHINDIG-1006
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: trunk
> Reporter: David Driscoll
> Fix For: trunk
>
> Attachments: HttpPreloader_patch.txt, MakeRequestClient_patch.txt, OAuthRequest_patch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> AuthType was not always being saved/maintained thru the entire workflow, would get overridden to "NONE" at times.
> IgnoreCache flag not always used. Added .setIgnoreCache call to HttpPreloader.java to obey IgnoreCache flag
> OAuth parameter Nonce not generated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1006) AuthType was not always being
saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce
not generated
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737749#action_12737749 ]
Paul Lindner commented on SHINDIG-1006:
---------------------------------------
David can you answer Brian's questions?
Looks like the preloader fix went in..
> AuthType was not always being saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce not generated
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1006
> URL: https://issues.apache.org/jira/browse/SHINDIG-1006
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 1.1-BETA1
> Reporter: David Driscoll
> Fix For: 1.1-BETA2
>
> Attachments: HttpPreloader_patch.txt, HtttpPreloader_patchB.txt, MakeRequestClient_patch.txt, OAuthRequest_patch.txt, OAuthRequestTest_patch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> AuthType was not always being saved/maintained thru the entire workflow, would get overridden to "NONE" at times.
> IgnoreCache flag not always used. Added .setIgnoreCache call to HttpPreloader.java to obey IgnoreCache flag
> OAuth parameter Nonce not generated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1006) AuthType was not always being
saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce
not generated
Posted by "David Driscoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Driscoll resolved SHINDIG-1006.
-------------------------------------
Resolution: Fixed
I have attached the patches and tests needed to resolve this issue.
Regards,
Dave
> AuthType was not always being saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce not generated
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1006
> URL: https://issues.apache.org/jira/browse/SHINDIG-1006
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: trunk
> Reporter: David Driscoll
> Fix For: trunk
>
> Attachments: HttpPreloader_patch.txt, MakeRequestClient_patch.txt, OAuthRequest_patch.txt, OAuthRequestTest_patch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> AuthType was not always being saved/maintained thru the entire workflow, would get overridden to "NONE" at times.
> IgnoreCache flag not always used. Added .setIgnoreCache call to HttpPreloader.java to obey IgnoreCache flag
> OAuth parameter Nonce not generated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SHINDIG-1006) AuthType was not always being
saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce
not generated
Posted by "David Driscoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Driscoll reopened SHINDIG-1006:
-------------------------------------
I will leave this open for now.
Patches and tests to resolve this issue are attached.
> AuthType was not always being saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce not generated
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1006
> URL: https://issues.apache.org/jira/browse/SHINDIG-1006
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: trunk
> Reporter: David Driscoll
> Fix For: trunk
>
> Attachments: HttpPreloader_patch.txt, MakeRequestClient_patch.txt, OAuthRequest_patch.txt, OAuthRequestTest_patch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> AuthType was not always being saved/maintained thru the entire workflow, would get overridden to "NONE" at times.
> IgnoreCache flag not always used. Added .setIgnoreCache call to HttpPreloader.java to obey IgnoreCache flag
> OAuth parameter Nonce not generated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1006) AuthType was not always being
saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce
not generated
Posted by "David Driscoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Driscoll updated SHINDIG-1006:
------------------------------------
Attachment: HtttpPreloader_patchB.txt
> AuthType was not always being saved/maintained, IgnoreCache flag not always used, OAuth parameter Nonce not generated
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1006
> URL: https://issues.apache.org/jira/browse/SHINDIG-1006
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: trunk
> Reporter: David Driscoll
> Fix For: trunk
>
> Attachments: HttpPreloader_patch.txt, HtttpPreloader_patchB.txt, MakeRequestClient_patch.txt, OAuthRequest_patch.txt, OAuthRequestTest_patch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> AuthType was not always being saved/maintained thru the entire workflow, would get overridden to "NONE" at times.
> IgnoreCache flag not always used. Added .setIgnoreCache call to HttpPreloader.java to obey IgnoreCache flag
> OAuth parameter Nonce not generated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.