[GitHub] [pulsar] merlimat commented on a change in pull request #12106: [pulsar-client] Fix NPE in pulsar bolt while publishing messages

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #12106:
URL: https://github.com/apache/pulsar/pull/12106#discussion_r712622946



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TypedMessageBuilderImpl.java
##########
@@ -284,7 +284,7 @@ public MessageMetadata getMetadataBuilder() {
 
     public Message<T> getMessage() {
         beforeSend();
-        return MessageImpl.create(msgMetadata, content, schema, producer.topic);
+        return MessageImpl.create(msgMetadata, content, schema, producer != null ? producer.getTopic() : null);

Review comment:
       In what case can we get that producer is null? 
   
   the field is defined as: 
   
   ```
       private transient final ProducerBase<?> producer;
   ```
   
   and we create the message builder starting from the producer. Would that mean that the message builder was serialized and passed around?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org