You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/17 01:12:55 UTC

[GitHub] [hudi] leesf commented on a diff in pull request #5572: [HUDI-3654] Preparations for hudi metastore.

leesf commented on code in PR #5572:
URL: https://github.com/apache/hudi/pull/5572#discussion_r874273449


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##########
@@ -459,6 +459,9 @@ private Stream<HoodieInstant> getCommitInstantsToArchive() {
 
   private Stream<HoodieInstant> getInstantsToArchive() {
     Stream<HoodieInstant> instants = Stream.concat(getCleanInstantsToArchive(), getCommitInstantsToArchive());
+    if (config.isMetastoreEnabled()) {
+      return Stream.empty();

Review Comment:
   For metastore implementation, is it possible to have something new like `MetastoreHoodieTiimelineArchiver` implement?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org