You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/08 21:20:20 UTC
[jira] [Work logged] (TS-4731) Change return type for
TSHttpTxnIsInternal and TSHttpSsnIsInternal
[ https://issues.apache.org/jira/browse/TS-4731?focusedWorklogId=28521&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28521 ]
ASF GitHub Bot logged work on TS-4731:
--------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/16 21:20
Start Date: 08/Sep/16 21:20
Worklog Time Spent: 10m
Work Description: GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/995
TS-4731: Changes return codes for IsInternal APIs
This changes the following APIs:
tsapi int TSHttpTxnIsInternal(TSHttpTxn txnp);
tsapi int TSHttpSsnIsInternal(TSHttpSsn ssnp);
In addition, this also removes the following APIs, that were previously
deprecated:
tsapi TS_DEPRECATED TSReturnCode TSHttpIsInternalRequest(TSHttpTxn txnp);
tsapi TS_DEPRECATED TSReturnCode TSHttpIsInternalSession(TSHttpSsn ssnp);
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4731
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/995.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #995
----
commit 205beb1f19818ec9e603b409ad332f31866e2703
Author: Leif Hedstrom <zw...@apache.org>
Date: 2016-09-08T20:56:16Z
TS-4731: Changes return codes for IsInternal APIs
This changes the following APIs:
tsapi int TSHttpTxnIsInternal(TSHttpTxn txnp);
tsapi int TSHttpSsnIsInternal(TSHttpSsn ssnp);
In addition, this also removes the following APIs, that were previously
deprecated:
tsapi TS_DEPRECATED TSReturnCode TSHttpIsInternalRequest(TSHttpTxn txnp);
tsapi TS_DEPRECATED TSReturnCode TSHttpIsInternalSession(TSHttpSsn ssnp);
----
Issue Time Tracking
-------------------
Worklog Id: (was: 28521)
Time Spent: 10m
Remaining Estimate: 0h
> Change return type for TSHttpTxnIsInternal and TSHttpSsnIsInternal
> ------------------------------------------------------------------
>
> Key: TS-4731
> URL: https://issues.apache.org/jira/browse/TS-4731
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Labels: incompatible
> Fix For: 7.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I'd like to propose that we modify these two APIs from:
> {code}
> tsapi TSReturnCode TSHttpTxnIsInternal(TSHttpTxn txnp);
> tsapi TSReturnCode TSHttpSsnIsInternal(TSHttpSsn snap);
> {code}
> to be
> {code}
> tsapi int TSHttpTxnIsInternal(TSHttpTxn txnp);
> tsapi int TSHttpSsnIsInternal(TSHttpSsn snap);
> {code}
> This is more inline with our current standards of using "int" as a boolean type. This is for example the prototype in TSVConnIsSsl() as well as in e.g. TSHttpTxnDebugSet(TSHttpTxn txnp, int on).
> This is an incompatible change though.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)