[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10177: feat: Switch from nosetest to pytest

[GitBox <gi...@apache.org>]

bkyryliuk commented on a change in pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#discussion_r446462101



##########
File path: scripts/python_tests.sh
##########
@@ -23,5 +23,5 @@ echo "Superset config module: $SUPERSET_CONFIG"
 
 superset db upgrade
 superset init
-nosetests --stop tests/load_examples_test.py
-nosetests --stop --exclude=load_examples_test tests
+pytest --maxfail=1  tests/load_examples_test.py

Review comment:
       my preference is not to count it, to me this is more a fixture setup rather than an actual test.
   However do not have a preference here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org