You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/16 10:45:22 UTC

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #217: [FLINK-27609] Tracking flink-version and flink-revision in FlinkDeploymentStatus

morhidi commented on code in PR #217:
URL: https://github.com/apache/flink-kubernetes-operator/pull/217#discussion_r873581362


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java:
##########
@@ -85,16 +86,29 @@ public void observe(FlinkDeployment flinkApp, Context context) {
         if (!isJmDeploymentReady(flinkApp)) {
             observeJmDeployment(flinkApp, context, observeConfig);
         }
+
         if (isJmDeploymentReady(flinkApp)) {
+            observeClusterInfo(flinkApp, observeConfig);

Review Comment:
   Fair point :) Moved it to (hopefully) the right spot. PTAL



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org