[GitHub] maskit commented on a change in pull request #1080: ENH: Apply `make format` into C++ client

[GitBox <gi...@apache.org>]

maskit commented on a change in pull request #1080: ENH: Apply `make format` into C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1080#discussion_r162364240
 
 

 ##########
 File path: pulsar-client-cpp/include/pulsar/Authentication.h
 ##########
 @@ -19,65 +19,68 @@
 #ifndef PULSAR_AUTHENTICATION_H_
 #define PULSAR_AUTHENTICATION_H_
 
-#include <vector>
-#include <string>
-#include <map>
-#include <boost/shared_ptr.hpp>
 #include <pulsar/Result.h>
 #include <boost/make_shared.hpp>
+#include <boost/shared_ptr.hpp>
 
 Review comment:
   I'm not sure whether we can do this, but I think we should not touch `#include` lines for now. Because reordering the lines sometimes causes compile errors. Although we should fix such errors, it would require extra changes that goes beyond formatting.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services