You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/08 11:00:07 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #1890: Quarkus 1.9.0 post upgrade fixes
jamesnetherton opened a new pull request #1890:
URL: https://github.com/apache/camel-quarkus/pull/1890
Fixes some of the simpler 1.9.x upgrade tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1890: Quarkus 1.9.0 post upgrade fixes
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1890:
URL: https://github.com/apache/camel-quarkus/pull/1890#discussion_r501729284
##########
File path: pom.xml
##########
@@ -56,8 +56,6 @@
<guava.version>29.0-jre</guava.version>
<gson.version>2.8.5</gson.version>
<hapi.version>4.1.0</hapi.version>
- <httpclient.cache.version>4.5.5</httpclient.cache.version>
- <httpclient.version>4.5.12</httpclient.version><!-- keep in sync with both Camel and Quarkus -->
Review comment:
Is Quarkus managing these now?
##########
File path: pom.xml
##########
@@ -56,8 +56,6 @@
<guava.version>29.0-jre</guava.version>
<gson.version>2.8.5</gson.version>
<hapi.version>4.1.0</hapi.version>
- <httpclient.cache.version>4.5.5</httpclient.cache.version>
- <httpclient.version>4.5.12</httpclient.version><!-- keep in sync with both Camel and Quarkus -->
Review comment:
Haha, it was even me adding httpmime https://github.com/quarkusio/quarkus/blame/1.9.0.CR1/bom/application/pom.xml#L2851-L2855
Thanks for reminding!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1890: Quarkus 1.9.0 post upgrade fixes
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1890:
URL: https://github.com/apache/camel-quarkus/pull/1890#discussion_r501737197
##########
File path: pom.xml
##########
@@ -56,8 +56,6 @@
<guava.version>29.0-jre</guava.version>
<gson.version>2.8.5</gson.version>
<hapi.version>4.1.0</hapi.version>
- <httpclient.cache.version>4.5.5</httpclient.cache.version>
- <httpclient.version>4.5.12</httpclient.version><!-- keep in sync with both Camel and Quarkus -->
Review comment:
https://github.com/quarkusio/quarkus/blob/1.9.0.CR1/bom/application/pom.xml#L2846-L2855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1890: Quarkus 1.9.0 post upgrade fixes
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1890:
URL: https://github.com/apache/camel-quarkus/pull/1890#discussion_r501799743
##########
File path: pom.xml
##########
@@ -56,8 +56,6 @@
<guava.version>29.0-jre</guava.version>
<gson.version>2.8.5</gson.version>
<hapi.version>4.1.0</hapi.version>
- <httpclient.cache.version>4.5.5</httpclient.cache.version>
- <httpclient.version>4.5.12</httpclient.version><!-- keep in sync with both Camel and Quarkus -->
Review comment:
Haha, it was even me adding httpmime https://github.com/quarkusio/quarkus/blame/1.9.0.CR1/bom/application/pom.xml#L2851-L2855
Thanks for reminding!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1890: Quarkus 1.9.0 post upgrade fixes
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1890:
URL: https://github.com/apache/camel-quarkus/pull/1890#discussion_r501737197
##########
File path: pom.xml
##########
@@ -56,8 +56,6 @@
<guava.version>29.0-jre</guava.version>
<gson.version>2.8.5</gson.version>
<hapi.version>4.1.0</hapi.version>
- <httpclient.cache.version>4.5.5</httpclient.cache.version>
- <httpclient.version>4.5.12</httpclient.version><!-- keep in sync with both Camel and Quarkus -->
Review comment:
https://github.com/quarkusio/quarkus/blob/1.9.0.CR1/bom/application/pom.xml#L2846-L2855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #1890: Quarkus 1.9.0 post upgrade fixes
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1890:
URL: https://github.com/apache/camel-quarkus/pull/1890
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #1890: Quarkus 1.9.0 post upgrade fixes
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1890:
URL: https://github.com/apache/camel-quarkus/pull/1890
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1890: Quarkus 1.9.0 post upgrade fixes
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1890:
URL: https://github.com/apache/camel-quarkus/pull/1890#discussion_r501729284
##########
File path: pom.xml
##########
@@ -56,8 +56,6 @@
<guava.version>29.0-jre</guava.version>
<gson.version>2.8.5</gson.version>
<hapi.version>4.1.0</hapi.version>
- <httpclient.cache.version>4.5.5</httpclient.cache.version>
- <httpclient.version>4.5.12</httpclient.version><!-- keep in sync with both Camel and Quarkus -->
Review comment:
Is Quarkus managing these now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org