[jira] [Commented] (FLINK-6414) Use scala.binary.version in place of change-scala-version.sh

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994727#comment-15994727 ] 

ASF GitHub Bot commented on FLINK-6414:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3800
  
    I remember initially this did not work, because the variables where not properly resolved.
    It probably works now, because we force the shade plugin to be evaluated in each project (via the `force-shading` dependency). The shade plugin has the nice side effect of resolving variables.
    
    The thing we should be aware of here is that by going with this change, we must keep the `force-shading` hack. In some sense this PR brings the "force-shading" approach to conclusion.
    
    I remember that there was an alternate suggestion initially to not do the force-shading and rather have a more elaborate `change-scala-version.sh` script instead. 
    Just bringing this up so we are aware of the context/implications. I am okay with either approach.
    
    @rmetzger What is you take here?


> Use scala.binary.version in place of change-scala-version.sh
> ------------------------------------------------------------
>
>                 Key: FLINK-6414
>                 URL: https://issues.apache.org/jira/browse/FLINK-6414
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.3.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>
> Recent commits have failed to modify {{change-scala-version.sh}} resulting in broken builds for {{scala-2.11}}. It looks like we can remove the need for this script by replacing hard-coded references to the Scala version with Flink's maven variable {{scala.binary.version}}.
> I had initially realized that the change script is [only used for building|https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/building.html#scala-versions] and not for switching the IDE environment.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)